Bug 321559 – games-simultion/openttd-1.0.1: disable automagic linking to libtimidity, use timidity++ instead of aplaymidi, fix elogs.

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ai Locke Shinseiko (Wizzleby) 2010-05-26 14:14:00 UTC]

As it is in tree, openttd automagically links to libtimidity if it is installed.
This sound driver for openttd is not maintained and does not work. Patch forces --without-libtimidity.

Openttd also is built with aplaymidi as a midi player, this requires setting ALSA_PORTS to work, and either a sound card with midi ports, or running timidity++ as a service. Instead, we can use timidity as the extmidi driver, and have music work out of the box (requires conditional dep on timidity++)

Also integrated are cleanups of the elog text for legibility, clarity, and correctness. (Upstream pointed out a few inaccuracies amongst the general
incomprehensibility of the grammar (much of which was my fault, at least grammar-wise))

[Comment 1 Ai Locke Shinseiko (Wizzleby) 2010-05-26 14:46:19 UTC]

Created attachment 233003 [details, diff]
openttd-1.0.1.ebuild-general-fixes.patch

Summary of changes:
    Elog fixes, remove ALSA bit, was inaccurate. Music could be enabled without ALSA at all. Fix inaccuracy about case sensitivity in elog triggered when user omits the openmedia flag.

    Add +midi, and aplaymidi use flags. Use timidity when USE=midi (upstream default), aplaymidi only with aplaymidi use flag.

    Add conditional RDEP  on timidity++ when USE=midi but -aplaymidi.

[Comment 2 Ai Locke Shinseiko (Wizzleby) 2010-05-26 16:04:54 UTC]

Created attachment 233017 [details, diff]
openttd-1.0.1.ebuild-general-fixes.patch

Fix a semantics oversight from the last patch. --with-midi='/usr/bin/timidity' is default anyway, so don't set it.

Remove aplaymidi useflag.

[Comment 3 Ai Locke Shinseiko (Wizzleby) 2010-05-26 16:10:09 UTC]

Created attachment 233021 [details, diff]
metadata.xml.patch

useflag description for 'midi'

[Comment 4 Ai Locke Shinseiko (Wizzleby) 2010-05-26 16:30:42 UTC]

Created attachment 233023 [details, diff]
openttd-1.0.1.ebuild-timidity.patch

Use timidity++ instead of aplaymidi (patch 1 of 3)

[Comment 5 Ai Locke Shinseiko (Wizzleby) 2010-05-26 16:31:38 UTC]

Created attachment 233025 [details, diff]
openttd-1.0.1.ebuild-no-automagic-libtimidity.patch

Don't link to libtimidity.

[Comment 6 Ai Locke Shinseiko (Wizzleby) 2010-05-26 16:33:12 UTC]

Created attachment 233027 [details, diff]
openttd-1.0.1.ebuild-elog-fix.patch

Clean up elog messages (Patch 3 of 3)

[Comment 7 Ai Locke Shinseiko (Wizzleby) 2010-05-26 17:36:06 UTC]

Created attachment 233033 [details, diff]
openttd-1.0.1.ebuild.patch

Too many revisions, re-combining the patch to save me ~10m for every revision.
Add back the aplaymidi flag.

[Comment 8 Mr. Bones. (RETIRED) 2010-05-26 21:06:16 UTC]

in portage.