Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 320465 - dev-db/postgresql-server-*: copy/paste error in ebuilds
Summary: dev-db/postgresql-server-*: copy/paste error in ebuilds
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All All
: High normal
Assignee: PgSQL Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 21:41 UTC by Vincent Huisman
Modified: 2010-06-09 17:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Huisman 2010-05-18 21:41:57 UTC
In the first few lines of the pkg_config() functions, there is some code dealing with LC_* variables. After checking for a certain variable having any value at all, it is compared against LC_ALL. For LC_NUMERIC, the second check is made with LC_MONETARY rather than LC_NUMERIC.

Reproducible: Always

Steps to Reproduce:
1. (cd /usr/portage/dev-db/postgresql-server/; grep -n LC_MONETARY *.ebuild | grep LC_NUMERIC)
2. find all affected ebuilds and the number of the line with the error on it

Actual Results:  
postgresql-server-7.4.28.ebuild:156:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-7.4.29.ebuild:156:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.0.24.ebuild:157:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.0.25.ebuild:157:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.1.20.ebuild:160:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.1.21.ebuild:160:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.2.16.ebuild:165:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.2.17.ebuild:165:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.3.10.ebuild:170:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.3.11.ebuild:170:                    [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.4.3.ebuild:176:                     [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-8.4.4.ebuild:176:                     [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-9.0_alpha4.ebuild:180:                        [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
postgresql-server-9.0_beta1.ebuild:179:                 [ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&

Expected Results:  
(nothing)

Fix: The line
[ -n "${LC_NUMERIC}" -a "${LC_MONETARY}" != "${LC_ALL}" ] &&
should be changed to
[ -n "${LC_NUMERIC}" -a "${LC_NUMERIC}" != "${LC_ALL}" ] &&
in all affected ebuilds.

Workaround: use PG_INITDB_OPTS in /etc/conf.d/postgresql-*, or edit the ebuild :)

This error is not likely to cause any problems on 'normal' installations, so almost everyone should be fine.
Comment 1 Aaron W. Swenson gentoo-dev 2010-05-19 03:27:22 UTC
Doh! Thanks for spotting that. This script will be removed in favor of properly setting the environment variables. (This script was actually a workaround for old environment variables being preserved.)

Once the favored solution is in the tree, this bug will be closed.
Comment 2 Aaron W. Swenson gentoo-dev 2010-06-05 19:51:35 UTC
The -r1's have been committed to the tree. This bug should be resolved.