Aumix 2.8 supports both gtk2 and gtk1. But if I select both "gtk" and "gtk2" in USE, it ends up depending on both instead of just gtk2-related libs. The src_compile does correctly select which gtk to use, but the dependency on gtk1 is unnecessary and adds unnecessary packages at least on my system. I can also confirm that it works fine (with gtk2) on ppc so I think you can add it to KEYWORDS as stable, or at least unstable.
Created attachment 19823 [details, diff] Fix to only depend on gtk1 when gtk2 is not used. This patch modifies the ebuild to read: gtk? ( gtk2? ( >=x11-libs/gtk+-2.0.0 ) !gtk2? ( =x11-libs/gtk+-1.2* ) ) The format is based on the comments found here: http://article.gmane.org/gmane.linux.gentoo.devel/13076/match=use+gtk2
why not: gtk? ( || ( gtk2? ( >=x11-libs/gtk+-2.0.0 ) =x11-libs/gtk+-1.2* ) ) or gtk? ( gtk2? ( >=x11-libs/gtk+-2.0.0 ) : ( =x11-libs/gtk+-1.2* ) )
gtk QA ?
Yep, The patch is correct and reflects the current statement inside the build : if use gtk; then use gtk2 \ && myconf="${myconf} --without-gtk1" \ || myconf="${myconf} --without-gtk with-gtk1" else myconf="${myconf} --without-gtk --without-gtk1"; fi , however that looks sorta flawed, shouldn't there be a --with-gtk1 ? (no -- ) @SpanKY , No. We want to remove all cases of foo? ( bar : baz ) as that syntax was said to be deprecated, and is definitely harder to follow. Same goes for the || () statements. Don't use more logic than necessary, it makes for complexity which is to be avoided.
looks like it's already in there...
