I have a working venus ebuild that we also need to use on our infrastracture for planet, so note that this is a little urgent. I found those depedencies by running the runtests.py script. I'm sure rdflib should be enabled by a USE flag, but i'm not sure which one. darkside and beandog may give us more details about how venus works, as I am not familiar either with venus or the webapp eclass. I've wiped out the .bzr and *.pyc dirs/files from the snapshot tarball. Thanks
If i'm right there are two versions of planet: 1) not supported bzr with link from planetplanet.org 2) git version on the venus Where is upstream? The second repo doesn't have *.bzr and pyc files (current) b56bbcf46318cd2bf520f17b676ae5e63ad57636 .bzrignore => .gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.bzrignore b/.gitignore similarity index 85% rename from .bzrignore rename to .gitignore index a8f0629..eed0054 100644 --- a/.bzrignore +++ b/.gitignore @@ -2,3 +2,4 @@ .DS_Store cache *.pluginc +*.pyc
tampakrap: attach that ebuild here in the meantime? Your message was a bit unclear, as it keeps referencing things without the other side to look at.
Created attachment 231743 [details] venus ebuild
(In reply to comment #3) > Created an attachment (id=231743) [details] > venus ebuild > Review: -AUTHORS, README, TODO, don't exist, dodoc fails. -PLEASE look at where you are installing everything. Your configuration files and planet.py (et al) files have no need to be exposed on the web (in htdocs) -My echo's for comment #1, upstream moved to git now with a May 14th timestamp so I'd like to see the tarball named with that date to eliminate confusion. Thanks.
I've got a new tarball in woodpecker http://dev.gentoo.org/~tampakrap/venus-20100626.tar.bz2, replace SRC_URI with ${P}. I'm currently taking care of the other comments of darkside and will report back
New ebuild, new snapshot. Changes I made (based on viewvc ebuild) I'm installing every .py file on $(python_get_sitedir)/${PN}, examples/ in ${MY_HOSTROOTDIR}/conf and themes in ${MY_APPDIR}. Needs a src_test() function and maybe install docs/ in /usr/share/doc/${PF}? I'm CC'ing python team for suggestions/help
Created attachment 246583 [details] venus ebuild
The use of mod_python mod_wsgi django seems a little over-zealous. IMO it should just depend on mod_wsgi and maybe offer the CGI as an option.
Please call python_mod_optimize() and python_mod_cleanup() with correct paths (${PN}).
Created attachment 246877 [details] postinstall file
Created attachment 246882 [details] venus ebuild I'm getting there. Updates: 1) Fixed python_mod_cleanup and python_mod_optimize per Arfrever's request 2) Removed mod_python per djc's request 3) Add src_test function (needs fix, see below) 4) Added postinst-en.txt 5) Added html docs with dohtml Issues remaining: 1) I need more info about that CGI suggestion by djc (which means I didn't understand at all what you said :P) 2) src_test is broken. The commented code is how it should be done according to python guide, but it fails immediately. The way it is written now seems to run the runtests.py file, but it fails with: ====================================================================== ERROR: test_spiderThreads (tests.test_spider.SpiderTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/tmp/portage/www-apps/venus-20100626/work/venus/tests/test_spider.py", line 177, in test_spiderThreads urllib.urlopen('http://127.0.0.1:%d/' % _PORT).read() File "/usr/lib64/python2.6/urllib.py", line 86, in urlopen return opener.open(url) File "/usr/lib64/python2.6/urllib.py", line 205, in open return getattr(self, name)(url) File "/usr/lib64/python2.6/urllib.py", line 344, in open_http h.endheaders() File "/usr/lib64/python2.6/httplib.py", line 908, in endheaders self._send_output() File "/usr/lib64/python2.6/httplib.py", line 780, in _send_output self.send(msg) File "/usr/lib64/python2.6/httplib.py", line 739, in send self.connect() File "/usr/lib64/python2.6/httplib.py", line 720, in connect self.timeout) File "/usr/lib64/python2.6/socket.py", line 557, in create_connection raise error, msg IOError: [Errno socket error] [Errno 111] Connection refused ---------------------------------------------------------------------- Ran 218 tests in 4.139s FAILED (errors=1) Please test it
Matter of fact, I don't know if it is worth it having a src_test at all
(In reply to comment #11) > 2) src_test is broken. The commented code is how it should be done according > to python guide, but it fails immediately. testing() function looks correct. What error message occurs? > Ran 218 tests in 4.139s > > FAILED (errors=1) Failing tests might be disabled. Example: sed -e "s/test_spiderThreads/_&/" -i tests/test_spider.py
Created attachment 246889 [details] venus ebuild The testing() function works now after some depclean I did, maybe it was a local problem. The sed also works, but why doesn't the ebuild die when a test fails? (New snapshot btw)
(In reply to comment #14) > The sed also works, but why doesn't the ebuild die when a test fails? Maybe runtests.py returns 0 exit status when tests fail. Please change 'dev-lang/python[berkdb]' to '=dev-lang/python-2*[berkdb]'.
I guess I should contact upstream for both issues with the tests. Python dep changed locally
Created attachment 246916 [details] venus ebuild I contacted upstream for the runtests.py not exiting issue. The test failure seemed to be a local problem. I tried the ebuild two other boxes and tests finished successfully. I removed the sed and rearranged deps a bit. Also I added a couple more according to the documentation and the debian package http://packages.debian.org/lenny/planet-venus
Ignore my cgi comment, not sure what I was thinking. I don't understand how the django flag/dep makes sense for this. Do you know?
Yes, http://intertwingly.net/code/venus/docs/templates.html I'll also remove mod_wsgi dep as there are no wsgi files available (I may write some though in the near future). Ebuild will be moved to portage later today if there are no other suggestions/objections
Okay, fair enough.
Committed with a few changes, thanks to everyone involved. PS I added the tarball to /space/distfiles-local/ i'll change the SRC_URI as soon as it hits mirrors
