Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 319631 - =dev-tcltk/expect-5.44.1.15 failed to build with USE flag "-X"
Summary: =dev-tcltk/expect-5.44.1.15 failed to build with USE flag "-X"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: TCL/TK Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-13 22:21 UTC by Jonathan-Christofer Demay
Modified: 2010-05-25 11:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-tcltk/expect/files/expect-5.44.1.13_with-tk-no.patch (expect-5.44.1.13_with-tk-no.patch,3.39 KB, patch)
2010-05-25 09:59 UTC, Jonathan-Christofer Demay
Details | Diff
dev-tcltk/expect/expect-5.44.1.15-r1.ebuild (expect-5.44.1.15-r1.ebuild.patch,1.14 KB, patch)
2010-05-25 10:04 UTC, Jonathan-Christofer Demay
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan-Christofer Demay 2010-05-13 22:21:00 UTC
The configure script still try to find tk even though it is supposed to build without X support:

>>> Configuring source in /var/tmp/portage/dev-tcltk/expect-5.44.1.15/work/expect-5.44.1.15 ...
 * econf: updating expect-5.44.1.15/tclconfig/config.sub with /usr/share/gnuconfig/config.sub
 * econf: updating expect-5.44.1.15/tclconfig/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating expect-5.44.1.15/config.sub with /usr/share/gnuconfig/config.sub
 * econf: updating expect-5.44.1.15/config.guess with /usr/share/gnuconfig/config.guess
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --with-tcl=/usr/lib64 --with-tclinclude=/usr/lib64/tcl8.5/include/generic --with-tk=/usr/lib64 --with-tkinclude=/usr/include --enable-shared --enable-threads --enable-64bit --disable-symbols
checking for correct TEA configuration... ok (TEA 3.5)
configuring expect 5.44.1.15
checking for autoconf... yes
checking for Tcl configuration... found /usr/lib64/tclConfig.sh
checking for existence of /usr/lib64/tclConfig.sh... loading
checking for Tk configuration... configure: error: /usr/lib64 directory doesn't contain tkConfig.sh
Comment 1 Patrick Lauer gentoo-dev 2010-05-23 16:17:17 UTC
confirmed, it seems to unconditionally need Tk
Comment 2 Jonathan-Christofer Demay 2010-05-23 16:35:30 UTC
I think expect should be usable on system that don't have X11 (since it is mainly used to script commandline tools...)

This patch worked for me:
http://sourceforge.net/tracker/?func=detail&atid=313179&aid=2798801&group_id=13179
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2010-05-25 09:44:12 UTC
(In reply to comment #2)
> I think expect should be usable on system that don't have X11 (since it is
> mainly used to script commandline tools...)
> 
> This patch worked for me:
> http://sourceforge.net/tracker/?func=detail&atid=313179&aid=2798801&group_id=13179
> 

The linkis dead.
Comment 4 Jonathan-Christofer Demay 2010-05-25 09:57:46 UTC
The link indeed just died... >_> 

And I can't find any alternative link so I'll copy here the initial comment as well as the patch
Comment 5 Jonathan-Christofer Demay 2010-05-25 09:59:48 UTC
Created attachment 232865 [details, diff]
dev-tcltk/expect/files/expect-5.44.1.13_with-tk-no.patch

Initial Comment:

Patch made against cvs version 5.44.1.13 allowing to compile again without Tk
For example, when expect is only intented to run gcc test, that make no sense to require Tk installed.

I have not restored --with-x=no but changed existing --with-tk to support variant --with-tk=no.
If that's desirable, I could rework my patch to use again --with-x=no.

I have not changed the indentation despite having added one if fi level in 3 m4 macro.
That make the patch much smaller and more readable. I could update the indentation at maintainer request.
Comment 6 Jonathan-Christofer Demay 2010-05-25 10:04:01 UTC
Created attachment 232869 [details, diff]
dev-tcltk/expect/expect-5.44.1.15-r1.ebuild

And the patch for the ebuild.
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2010-05-25 11:01:33 UTC
+  25 May 2010; Justin Lecher <jlec@gentoo.org> expect-5.44.1.15.ebuild,
+  +files/expect-5.44.1.15_with-tk-no.patch:
+  Fix for build w/o tk, #319631; thanks Jonathan-Christofer Demay for
+  digging out the patch
+