Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 319051 - x11-libs/goffice-0.8.3 has broken intltool rules
Summary: x11-libs/goffice-0.8.3 has broken intltool rules
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: GNOME Office (OBSOLETE)
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2010-05-09 12:55 UTC by Priit Laes (IRC: plaes)
Modified: 2010-05-16 10:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2010-05-09 12:55:28 UTC
Please add following snippet to src_prepare():
[snip]
        # Fix intltoolize broken file, see upstream #577133
        sed "s:'\^\$\$lang\$\$':\^\$\$lang\$\$:g" -i po/Makefile.in.in \
                || die "sed failed"
[/snip]
Comment 1 Pacho Ramos gentoo-dev 2010-05-09 13:14:50 UTC
Only one question, how did you detected this issue?
Comment 2 Priit Laes (IRC: plaes) 2010-05-09 13:23:17 UTC
(In reply to comment #1)
> Only one question, how did you detected this issue?
> 

evasdk gave me following snippet:

Add this file as /etc/portage/bashrc  (also set executable):
[snip]
#!/bin/bash

post_src_prepare() {
	if [ ! -e "${S}/po/Makefile.in.in" ]; then
		return 0
	fi

	checksum=$(md5sum "${S}/po/Makefile.in.in" | cut -f1 -d' ')
	tempfile=$(tempfile)

	cat >> $tempfile <<EOF
26d0fa167a5a49e7f2b57b99d08c6586
f81285d13b63167be6981aad0e1a2038
955fb57559c7d112f749e185fc34e07f
EOF

	if grep -q "$checksum" $tempfile; then
		eerror "Bad intltool rules detected"
		die "Bad intltool rules detected"
	fi
}
[/snip]
Comment 3 Pacho Ramos gentoo-dev 2010-05-09 14:08:54 UTC
Thanks a lot :-)

In this exact case seems that it installs the same with or without broken rules, then, I am not sure about committing that fix since Eva didn't also added the sed command when he bumped 0.8.1 version (also affected by this).

I will ask then to the rest of the team
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-05-16 10:03:04 UTC
+  16 May 2010; Gilles Dartiguelongue <eva@gentoo.org> goffice-0.8.3.ebuild:
+  Fix intltool rules, bug #319051.

Thanks for reporting.