Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 317319 - media-video/vlc-1.1.0 VDPAU support
Summary: media-video/vlc-1.1.0 VDPAU support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords:
Depends on: 317317
Blocks:
  Show dependency tree
 
Reported: 2010-04-26 15:15 UTC by Frank Richter
Modified: 2010-05-15 08:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild (vlc-1.1.0_pre2-r1.ebuild,11.72 KB, text/plain)
2010-04-26 15:16 UTC, Frank Richter
Details
Diff to vlc-1.1.0_pre2 ebuild for VDPAU additions (vlc-1.1.0_pre2+vdpau.diff,1.70 KB, patch)
2010-04-26 16:16 UTC, Frank Richter
Details | Diff
Patch for libva support, against vlc-1.1.9999 ebuild (vlc-1.1.9999-libva.diff,2.12 KB, text/plain)
2010-05-12 15:49 UTC, Frank Richter
Details
Patch for libva support, against vlc-1.1.9999 ebuild (vlc-1.1.9999-libva.diff,2.12 KB, patch)
2010-05-12 15:50 UTC, Frank Richter
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Richter 2010-04-26 15:15:19 UTC
Attached ebuild extends vlc-1.1.0_pre2 to support a 'vdpau' use flag.

The use flag enables the "libva" configure option (and pulls in further requires dependencies, of course).

Reproducible: Always
Comment 1 Frank Richter 2010-04-26 15:16:01 UTC
Created attachment 229257 [details]
Proposed ebuild
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2010-04-26 16:02:00 UTC
Please attach unified diffs (diff -u) when you did changes to an ebuild. That would be much more handy for our devs.
Comment 3 Frank Richter 2010-04-26 16:16:28 UTC
Created attachment 229261 [details, diff]
Diff to vlc-1.1.0_pre2 ebuild for VDPAU additions
Comment 4 Frank Richter 2010-04-26 16:17:19 UTC
(In reply to comment #2)
> Please attach unified diffs (diff -u) when you did changes to an ebuild. That
> would be much more handy for our devs.

Sure, here you go.

Comment 5 Frank Richter 2010-04-26 16:22:10 UTC
Something else I just want to note: the use flag is called "vdpau", mostly because ffmpeg uses that same flag. If you wanted to be accurate, the flag would have to be "vaapi"(or "libva") - since that is what VLC actually uses.

(In general, "vdpau" and "vaapi" are sort of independent - libva doesn't require vdpau; conversely, an application may use vdpau directly and not through vaapi.)
Comment 6 Alexis Ballier gentoo-dev 2010-04-27 12:01:39 UTC
please attach diffs to 1.1.9999 and -9999; pre2 will never be unmasked and i'll use 1.1.9999 for future releases.

i'd prefer the useflag named libva; i don't think it's dependant on vdpau and vlc seems to only need libva and libva-x11

the configure script will die if --disable-avcodec and --enable-libva is given, you should use vlc_use_force and { vlc_use_enable_force at the end of the econf line }

this means you'll need to add the ffmpeg dep under the libva/vdpau useflag rather than duplicating it under the ffmpeg useflag
Comment 7 Frank Richter 2010-05-12 15:49:32 UTC
Created attachment 231235 [details]
Patch for libva support, against vlc-1.1.9999 ebuild

Worked in suggestions.

Note, the patch against vlc-9999.ebuild is exactly the same, so I won't attach that as well :p
Comment 8 Frank Richter 2010-05-12 15:50:47 UTC
Created attachment 231237 [details, diff]
Patch for libva support, against vlc-1.1.9999 ebuild

Same file, but properly marked as patch.
Comment 9 Alexis Ballier gentoo-dev 2010-05-15 08:57:30 UTC
patch applied, thanks; the useflag is named vaapi in the end; to match ffmpeg