Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 316999 - x11-libs/xpyb: Verify and potentially improve Python-related code
Summary: x11-libs/xpyb: Verify and potentially improve Python-related code
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-24 18:41 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2015-10-03 09:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (xpyb.patch,1.10 KB, patch)
2011-11-13 07:03 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (xpyb.patch,1012 bytes, patch)
2011-11-17 17:34 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (xpyb.patch,1.05 KB, patch)
2011-11-20 22:23 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-24 18:41:41 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-13 07:03:02 UTC
Created attachment 292355 [details, diff]
ebuild patch

Have no idea how why, can't set EAPI higher than 2.
depends on python2.  ABIs {2,6 2,7 3,1 ,32} tested.
ALL emerges AOK.

Note 

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * error.c:88: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * cookie.c:137: warning: dereferencing type-punned pointer will break strict-aliasing rules

--------------------------------------------------------
* Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://xcb.freedesktop.org/ http://pypi.python.org/pypi/xpyb
Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-14 16:54:51 UTC
(In reply to comment #1)

You should use x-modular_src_install() in src_install().
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2011-11-17 17:34:56 UTC
Created attachment 292927 [details, diff]
revised ebuild patch
Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-20 02:11:34 UTC
(In reply to comment #3)

So is python_convert_shebangs() needed or not?
x-modular_src_install() would have to be explicitly called in src_install() only when src_install() contained also other things.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-20 22:23:48 UTC
Created attachment 293235 [details, diff]
revised ebuild patch

repoman informed to update to eclass xorg-2.
python_mod_optimize required, however for the second time,

 python_mod_optimize(): Missing files or directories

 * Removing unnecessary /usr/lib64/python2.7/site-packages/xcb/xcb.a
 * Removing unnecessary /usr/lib64/python2.7/site-packages/xcb/xcb.a
 * Removing unnecessary /usr/lib64/python2.7/site-packages/xcb/xcb.la (forced)
I've left the python_mod_optimize && python_mod_cleanup
commented out for when the above confusion over python_mod_optimize is sotred
Comment 6 Pacho Ramos gentoo-dev 2015-10-03 09:29:33 UTC
This approach was changed by the -r1 python eclasses