Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 31685 - imhangul 0.9.7 release
Summary: imhangul 0.9.7 release
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Jay Kwak (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2003-10-21 09:36 UTC by Park Ji-in
Modified: 2003-11-16 08:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
imhangul-0.9.7.ebuild (update) (imhangul-0.9.7.ebuild,594 bytes, text/plain)
2003-10-21 09:43 UTC, Park Ji-in
Details
imhangul-0.9.7.ebuild (update) (imhangul-0.9.7.ebuild,699 bytes, text/plain)
2003-10-21 10:11 UTC, Park Ji-in
Details
imhangul-0.9.7.ebuild (update) (imhangul-0.9.7.ebuild,875 bytes, text/plain)
2003-11-12 20:39 UTC, Jay Kwak (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Park Ji-in 2003-10-21 09:36:54 UTC
hello,
Imhangul is gtk2 input module, for Korean.

and it's very useful for korean.

please update portage's version. we can just use old one.

and, please assign to cjk@ or, jayskwak@ - korean gentoo dev

thanks.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Park Ji-in 2003-10-21 09:43:25 UTC
Created attachment 19592 [details]
imhangul-0.9.7.ebuild (update)

simple ebuild.
Comment 2 Park Ji-in 2003-10-21 10:11:52 UTC
Created attachment 19593 [details]
imhangul-0.9.7.ebuild (update)

modified version ( first one doesnt install files at all )
Comment 3 Jay Kwak (RETIRED) gentoo-dev 2003-10-23 08:06:58 UTC
Hi.. Park...

Your ebuild work fine and I appreciate your reporting.
By the way, I would like to add 

src_compile() {
  econf || die
  emake || die
}

because it is a general tendency. :)

p.s I can get a cjk@gentoo.org mail. Thanks.
Comment 4 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-11-12 11:03:10 UTC
Park, just one more question - do you mind if I ask you to add Gentoo
copyright at the top of your ebuild?

P.S. 
I think both to have src_compile() and not to have src_compile() are
alright. Some prefer not having it while others don't; however, I
agree with Jay because of descriptive feature of ebuilds (that is,
if you write it explicitly it becomes clearer what process the ebuild
should follow and I think it's worth to do despite ebuilds get longer
and redundant).
Comment 5 Park Ji-in 2003-11-12 18:40:50 UTC
of course, I dont mind. (and for the ebuild I will post).
Comment 6 Jay Kwak (RETIRED) gentoo-dev 2003-11-12 20:39:06 UTC
Created attachment 20671 [details]
imhangul-0.9.7.ebuild (update)

I added copyright and src_compile()
Comment 7 Jay Kwak (RETIRED) gentoo-dev 2003-11-16 08:26:54 UTC
I changed keyword to ~x86 ~ppc and committed it.