Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 31668 - portage adds a char too much to the Makefile of vanilla-sources
Summary: portage adds a char too much to the Makefile of vanilla-sources
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: x86-kernel@gentoo.org (DEPRECATED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-21 06:07 UTC by Nicolai Lissner
Modified: 2004-01-04 11:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolai Lissner 2003-10-21 06:07:11 UTC
This really surprised me, I just realized, when a user emerging vanilla kernel gets a slightly modified source-code -- why does gentoo change the Makefile of the vanilla-sources? Ok changes in DocBook are clear...but what's this from linux-2.4.22/Makefile: ?
4c4
< EXTRAVERSION = 
---
> EXTRAVERSION =
77c77
< export        INSTALL_PATH=/boot
---
> #export       INSTALL_PATH=/boot

This leads to confusion if a user merges vanilla-sources to *patch* it manually. Patches are rejected - line 4 is different -- it does not look different but it is, because "gentoo-version" of vanilla contain a space-char behind "EXTRAVERSION =" but the original source does not.

Please, do not change anything in the vanilla-sources - people would expect to find a really unmodified version if they merge vanilla.

I'm not sure, what is causing this change - I guess it could be a portage-bug, since the ebuild uses "kernel_universal_unpack" - and does not change the sourcecode directly in the ebuild.
Comment 1 Brian Jackson (RETIRED) gentoo-dev 2003-10-21 16:32:51 UTC
The INSTALL_PATH is a legitimate change to make "make install" behave correctly.
The EXTRAVERSION is a sideeffect of the the sed rule to set the kernel version
on patched kernels, it's not easily fixed, but I'll look into it.
Comment 2 Tim Yamin (RETIRED) gentoo-dev 2004-01-04 11:04:24 UTC
This seems to be fixed - I just merged the latest vanilla-sources-2.4.22 to check this and the INSTALL_PATH is no longer commented and the EXTRAVERSION seems to match the true vanilla one...