316411 – app-admin/eselect-opengl: cleanup and improvements

Bug 316411 - app-admin/eselect-opengl: cleanup and improvements

Summary: app-admin/eselect-opengl: cleanup and improvements

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Unspecified (show other bugs)
Hardware:	All Linux

Importance:	High enhancement (vote)
Assignee:	Gentoo X packagers

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:

Reported:	2010-04-20 19:00 UTC by Michał Górny
Modified:	2010-05-15 14:39 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
The mentioned patch (eselect-opengl.diff,6.97 KB, patch) 2010-04-20 19:00 UTC, Michał Górny	Details \| Diff
Mangled 'locals' (eselect-opengl-r2.diff,7.31 KB, patch) 2010-04-24 07:50 UTC, Michał Górny	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2010-04-20 19:00:14 UTC

I've cleaned up the eselect-opengl script a little and I'm attaching a patch here. Mostly these are cosmetic changes and small fixes. The patch also includes changes related to bug #315347 (adding the GL/ include subdirectory support).

One thing I'm not really not sure about is the ${ROOT} modification. This is because I am unable to get the idea of replacing all of its' occurences in path — I assumed that was only a mistake.

Comment 1 Michał Górny archtester

2010-04-20 19:00:40 UTC

Created attachment 228541 [details, diff]
The mentioned patch

Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev

2010-04-23 18:51:58 UTC

after reading it multiple times only one thing i dont like on current patch:

local var var2 var3
should be:
local var
local var2
local var3

:P good work :]

Comment 3 Michał Górny archtester

2010-04-24 07:50:12 UTC

Created attachment 228963 [details, diff]
Mangled 'locals'

Hope you'll like this one more.

Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev

2010-05-15 14:39:14 UTC

Added to svn. Will be part of next release.