Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315823 - net-misc/geekcredit: Verify and potentially improve Python-related code
Summary: net-misc/geekcredit: Verify and potentially improve Python-related code
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard: Pending removal: 2015-04-19
Keywords: PMASKED
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-18 02:16 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2015-04-26 12:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (geekcredit.patch,994 bytes, patch)
2011-11-25 09:39 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (geekcredit.patch,1.15 KB, patch)
2011-11-26 11:58 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-18 02:16:08 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 David Abbott (RETIRED) gentoo-dev 2010-05-01 01:15:50 UTC
Latest is from 2004, does anyone use this?
https://gna.org/projects/geekcredit/
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2011-11-23 09:40:38 UTC
EAPI="3"
DEPEND=">=dev-lang/python-2.4
seem to be all required here, decided not enough to warrant making a patch for better or worse, and I don't think anyone uses this
Comment 3 Arfrever Frehtes Taifersar Arahesis 2011-11-23 21:07:02 UTC
(In reply to comment #2)

This package doesn't support Python 3:

$ /usr/bin/GCPocket.py --help
  File "/usr/bin/GCPocket.py", line 33
    print "Usage: GcPocket.exe with one of commands:"
                                                    ^
SyntaxError: invalid syntax
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2011-11-24 23:24:18 UTC
EAPI="3"
DEPEND="2"
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-25 09:39:31 UTC
Created attachment 293687 [details, diff]
ebuild patch

sorry for that last rubbish, was too tired at the time.  Made a reg patch.
Now I finally see how the shebang fixer takes its arguments and works.  Didn't take too many dozens!!
Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-25 23:02:35 UTC
(In reply to comment #5)

PYTHON_DEPEND="2"

DEPEND="app-crypt/gnupg"
RDEPEND="${DEPEND}"

pkg_postinst() {
	python_mod_optimize GeekCredit.py
}

pkg_postrm() {
	python_mod_cleanup GeekCredit.py
}
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2011-11-26 11:58:48 UTC
Created attachment 293817 [details, diff]
revised ebuild patch
Comment 8 Pacho Ramos gentoo-dev 2015-02-08 23:44:38 UTC
I wonder if anyone is still using this (dead since 2004), I would simply treeclean it
Comment 9 Pacho Ramos gentoo-dev 2015-04-26 12:51:13 UTC
dropped