Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315449 - sys-boot/grub-1.98 add nls flag
Summary: sys-boot/grub-1.98 add nls flag
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-15 12:34 UTC by Chris Beswick
Modified: 2010-07-06 00:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch against current grub-1.98.ebuild (grub-1.98-nls.patch,644 bytes, patch)
2010-04-15 12:37 UTC, Chris Beswick 		Details | Diff
Patch against current grub-1.98.ebuild (grub-1.98-disable-nls.patch,5.07 KB, patch)
2010-04-17 11:31 UTC, Chris Beswick 		Details | Diff
Patch against current grub-1.98.ebuild (grub-1.98-nls.patch,1.18 KB, patch)
2010-04-17 11:32 UTC, Chris Beswick 		Details | Diff
Patch to grub-1.98 to remove dependancy on gettext (grub-1.98-disable-nls.patch,5.07 KB, patch)
2010-04-17 11:33 UTC, Chris Beswick 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Beswick 2010-04-15 12:34:07 UTC 
The configure script accepts --disable-nls, and without it, people who have nls useflag turned off, and therefor no gettext will be unable to install.

Its a trivial patch to add an nls useflag so that the grub ebuild behaves as most other core compents do.

Therefor I would like to request that such a useflag be added, to make it behave better.

The only other option seems to be to add a dependancy to gettext, which seems wrong.

Reproducible: Always
Comment 1 Chris Beswick 2010-04-15 12:37:32 UTC 
Created attachment 227897 [details, diff]
Patch against current grub-1.98.ebuild
Comment 2 Chris Beswick 2010-04-15 12:54:15 UTC 
Seems my "simple" patch doesn't work...
Comment 3 Chris Beswick 2010-04-17 11:31:24 UTC 
Created attachment 228117 [details, diff]
Patch against current grub-1.98.ebuild
Comment 4 Chris Beswick 2010-04-17 11:32:20 UTC 
Created attachment 228119 [details, diff]
Patch against current grub-1.98.ebuild

Correct patch this time
Comment 5 Chris Beswick 2010-04-17 11:33:20 UTC 
Created attachment 228121 [details, diff]
Patch to grub-1.98 to remove dependancy on gettext

Not sure this is a good idea, but it works for me and lets me not have gettext.
Comment 6 Charl van Deventer 2010-04-21 10:01:10 UTC 
Well, I'm getting something that looks like this bug, just I do have nls enabled.  I am unsure if it is related, but this line gives me the clue it also has to do with gettext:

Can't locate Locale/gettext.pm in @INC (@INC contains: /usr/lib64/perl5/site_perl/5.10.1/x86_64-linux /usr/lib64/perl5/site_perl/5.10.1 /usr/lib64/perl5/site_perl /usr/lib64/perl5/vendor_perl/5.10.1/x86_64-linux /usr/lib64/perl5/vendor_perl/5.10.1 /usr/lib64/perl5/vendor_perl /usr/lib64/perl5/5.10.1/x86_64-linux /usr/lib64/perl5/5.10.1 .) at /usr/bin/help2man line 29.

Working off a really old bug on an unrelated package but with the same message tho I tried running 'perl-cleaner reallyall' which fixed the issue.
Comment 7 SpanKY gentoo-dev 2010-07-06 00:21:16 UTC 
i have no problem with the USE=nls changes to the ebuild wrt econf, but applying patches is out.  grub-2 changes should go through upstream.