Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315369 - move cleanup_fonts() into font.eclass
Summary: move cleanup_fonts() into font.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Fonts Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-15 02:13 UTC by Ryan Hill (RETIRED)
Modified: 2010-07-09 03:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
font.eclass.diff (font.eclass.diff,1.58 KB, patch)
2010-04-17 00:21 UTC, Ryan Hill (RETIRED)
Details | Diff
x-eclasses.diff (x-eclasses.diff,3.14 KB, patch)
2010-07-03 09:04 UTC, Ryan Hill (RETIRED)
Details | Diff
font.eclass.diff (font.eclass.diff,2.16 KB, text/plain)
2010-07-03 10:21 UTC, Ryan Hill (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hill (RETIRED) gentoo-dev 2010-04-15 02:13:17 UTC
it looks like the problem of generated font files being left around after package removal affects more than just xorg fonts, so I'd like to move this function into font.eclass and generalize it so it can be run recursively on /usr/share/fonts during font_pkg_postrm.  hopefully this will help prevent things like bug #311923.
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2010-04-16 18:24:08 UTC
Go for it :]
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2010-04-17 00:21:18 UTC
Created attachment 228083 [details, diff]
font.eclass.diff

i'll apply this in a couple days if no one sees any glaring errors.
Comment 3 Rémi Cardona (RETIRED) gentoo-dev 2010-04-17 05:29:38 UTC
Looks good, thanks Ryan :)
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2010-04-17 09:39:59 UTC
You know that the RM itself is commented out?
Comment 5 Ryan Hill (RETIRED) gentoo-dev 2010-04-20 04:02:54 UTC
yes. :P
committed.
Comment 6 Peter Volkov (RETIRED) gentoo-dev 2010-05-14 11:53:46 UTC
Reopening, since I have one question:

This function removes directories which were created by media-fonts/font-alias:

$ qlist media-fonts/font-alias 
/usr/share/fonts/75dpi/fonts.alias
/usr/share/fonts/100dpi/fonts.alias
/usr/share/fonts/cyrillic/fonts.alias
/usr/share/fonts/misc/fonts.alias
/usr/share/doc/font-alias-1.0.2/ChangeLog.bz2

If this aliases are needed then we should not clean them. If we don't need them, then why this package? :)
Comment 7 Ryan Hill (RETIRED) gentoo-dev 2010-05-14 23:43:52 UTC
that was due to bug #249190, but it seems we might need to rethink it.
Comment 8 Ryan Hill (RETIRED) gentoo-dev 2010-07-03 09:04:18 UTC
Created attachment 237345 [details, diff]
x-eclasses.diff

Remove cleanup_fonts from the xorg eclasses since it's now handled by font.eclass.
Comment 9 Ryan Hill (RETIRED) gentoo-dev 2010-07-03 10:21:55 UTC
Created attachment 237353 [details]
font.eclass.diff

This should do it.  I also documented the function so I don't have to spend another hour trying to remember how the hell this works six months from now.
Comment 10 Ryan Hill (RETIRED) gentoo-dev 2010-07-09 03:44:21 UTC
Applied.