Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315247 - www-client/chromium-9999: failed patch chromium-drop_sse2.patch
Summary: www-client/chromium-9999: failed patch chromium-drop_sse2.patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-14 10:18 UTC by Auke Booij (tulcod)
Modified: 2010-05-05 19:09 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
chromium-drop_sse2.patch.out (chromium-drop_sse2.patch.out,3.19 KB, text/plain)
2010-04-14 10:21 UTC, Auke Booij (tulcod)
Details
new patch.out (chromium-drop_sse2-r1.patch.out,2.64 KB, text/plain)
2010-05-01 14:33 UTC, Daniel Douglas
Details
chromium-drop_sse2-r2.patch (chromium-drop_sse2-r2.patch,368 bytes, patch)
2010-05-04 14:59 UTC, cyrillic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Auke Booij (tulcod) 2010-04-14 10:18:50 UTC
chromium-drop_sse2.patch failed on www-client/chromium-9999. i'll attach chromium-drop_sse2.patch.out in a sec.

Reproducible: Always

Steps to Reproduce:
Comment 1 Auke Booij (tulcod) 2010-04-14 10:21:06 UTC
Created attachment 227767 [details]
chromium-drop_sse2.patch.out

chromium-drop_sse2.patch.out
Comment 2 Moritz Schönauer 2010-04-16 21:49:47 UTC
I had some conversation with the chromium-guys:

<rubenbb> hmm, reading the relevant chromium ticket, it looks like that patch is completely unnecessary - code.google.com/p/chromium/issues/detail?id=9007
<rubenbb> or even http://code.google.com/p/chromium/issues/detail?id=9007
<rubenbb> if I were you, I'd just remove that patch and build and complain to whoever left that in
Comment 3 Keith Rusler 2010-04-18 19:31:51 UTC
Any status on the removal of the patch?
Comment 4 Bernard Cafarelli gentoo-dev 2010-04-19 07:01:36 UTC
Here are some flags that get appended to CFLAGS without this patch (on i386):
-m32 -mmmx -march=pentium4 -msse2 -mfpmath=sse

So it is definitly still needed, working on a new version. In Gentoo we do mind about build systems forcibly setting CFLAGS like that ;)
Comment 5 Bernard Cafarelli gentoo-dev 2010-04-19 09:10:40 UTC
Patch updated (+files/chromium-drop_sse2-r1.patch), thanks for the report!
Comment 6 Daniel Douglas 2010-05-01 14:33:46 UTC
Created attachment 229897 [details]
new patch.out
Comment 7 Daniel Douglas 2010-05-01 14:36:04 UTC
Similar problem with the new patch (attached). Reopen if anyone else can duplicate this (or tell me to create a new bug)
Comment 8 Anthony Scopatz 2010-05-03 17:16:09 UTC
(In reply to comment #7)
> Similar problem with the new patch (attached). Reopen if anyone else can
> duplicate this (or tell me to create a new bug)
> 

I am able to duplicate this bug with the new patch, unfortunately.
Comment 9 Bernard Cafarelli gentoo-dev 2010-05-04 05:31:49 UTC
I guess it's already time for -r2 version of the patch, thanks for the notification
Comment 10 cyrillic 2010-05-04 14:59:41 UTC
Created attachment 230273 [details, diff]
chromium-drop_sse2-r2.patch

Here is a new patch that applies better than the -r1 patch.
Comment 11 Bernard Cafarelli gentoo-dev 2010-05-05 12:33:23 UTC
Even better:
"Add a gyp flag for disabling sse2.  This makes it easier for
distros to disable sse2."

I've updated -9999 ebuild, thanks for the notification. And this time I think this will stay fixed as we do not need to patch anymore :)
Comment 12 Anthony Scopatz 2010-05-05 19:09:52 UTC
Great, this now works for me.  Thanks a lot!