Hi, ufed doesnt look for use.desc and use.local.desc in the PORTDIR_OVERLAY directory. As emerge itself concerns these files (i get an added flag displayed with emerge -pv, e.g.) I think ufed should, too. regards Markus Reproducible: Always Steps to Reproduce: 1. cp /usr/portage/profiles/use.local.desc /usr/local/portage/profiles 2. echo "net-mail/cyrus-imapd:autocreate - Enable INBOX autocreate support (patch)" >>/usr/local/portage/profiles 3. emerge -pv cyrus-imapd [ebuild R ] net-mail/cyrus-imapd-2.1.15 -afs -snmp +ssl -kerberos -ipv6 -cyrus-imapd:autocreate * local use flag is shown * 4. run ufed - it does not show the new use flag Expected Results: ufed should read the use.[local.]desc in PORTDIR_OVERLAY too. version used: app-portage/ufed-0.34
typo.. diff follows ;-) 1. cp /usr/portage/profiles/use.local.desc /usr/local/portage/profiles -2. echo "net-mail/cyrus-imapd:autocreate - Enable INBOX autocreate support (patch)" >>/usr/local/portage/profiles +2. echo "net-mail/cyrus-imapd:autocreate - Enable INBOX autocreate support (patch)" >>/usr/local/portage/profiles/use.local.desc 3. emerge -pv cyrus-imapd
Created attachment 19488 [details, diff] Adds $PORTDIR_OVERLAY/profiles/use.{,local.}desc support. This patch is applied against ufed.pl so that it can be easily integrated with the ebuild. To use it place the diff in /usr/portage/app-portage/ufed/files/ and then add: src_unpack() { unpack ${A} cd ${S} epatch ${FILESDIR}/${P}-overlay.diff } to the ufed-0.34.ebuild. Then, reemerge ufed for the patched version.
Agreed, anything in PORTDIR_OVERLAY should overrule the standard files. I will investigate the patch provided and upgrage ufed within a couple of days. Thank you Doug for the patch.
overlay is a space delimited list, btw.
Created attachment 40618 [details, diff] ufed-0.35-overlay.diff I've updated the patch to support multiple overlay directories. Is there anything wrong with this approach that ufed doesn't yet support this, or has this simply been forgotten about?
Well, ufed is maintainlerless for several months now ...
Also portage doesn't read use*.desc even from $PORTDIR.
> Well, ufed is maintainlerless for several months now ... That's unfortunate. Thanks for taking the time to look at ufed's bugreports, then. > Also portage doesn't read use*.desc even from $PORTDIR. portage doesn't have any need for descriptions or even a list of flags. ufed does.
the last comment was just a reply for the original statement about portage looking at use*.desc in overlays. Right now the profiles/ directory in an overlay has absolutely no meaning to portage, that's why I'm not sure if I like this functionality or not.
Oh, sorry, I misunderstood, then. I would like to see this functionality in ufed because the only way with an unmodified ufed to enable use flags for ebuilds in an overlay directory is to modify /usr/portage/profiles/use*.desc and add them to rsync_excludes. I think the problem with that is obvious. use*.desc files in an overlay seem to me, and apparently the bug reporter too, like the best solution for this. If you have a better idea for this, I would be happy to modify the patch.
Ok, I'm considering this for the patchset for the next (and I hope last) ufed version, however if I read it correctly it won't work with those cascaded profiles that don't have a make.defaults themself but only inherit one, so I'm holding this one back for now.
Created attachment 46713 [details, diff] ufed-0.35-overlay.patch Hi, you're right, it would fail when make.defaults is missing, though that's a bug of its own, since it also fails in an unpatched ufed. I modified this patch to try and handle it properly, and it's even uglier than the fix for get_make_defaults_flags :) get_make_conf_flags also assumes /etc/make.profile/make.defaults is the only make.defaults used, by the way. A fix for that should be similar to a fix for get_make_defaults_flags. I'll report that as a new bug if I can manage to create a patch for that.
Should be working with ufed 0.36. Please reopen if that still has problems.
