315231 – net-p2p/amule-2.2.6 src_unpack() is incorrect

Bug 315231 - net-p2p/amule-2.2.6 src_unpack() is incorrect

Summary: net-p2p/amule-2.2.6 src_unpack() is incorrect

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo net-p2p team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-04-14 09:20 UTC by gtlinuxman
Modified:	2010-04-16 14:15 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description gtlinuxman 2010-04-14 09:20:21 UTC

src_unpuck() function is incorrect

Reproducible: Always

Steps to Reproduce:
1. emerge amule
Actual Results:  
>>> Unpacking source...                           
 * Applying amule-2.2.6-fallocate.diff ...        
                                                  
 * Failed Patch: amule-2.2.6-fallocate.diff !     
 *  ( /usr/portage/net-p2p/amule/files/amule-2.2.6-fallocate.diff )

ll /var/tmp/portage/net-p2p/amule-2.2.6/work
total 0


Expected Results:  
package should be unpacked

===========================================================
amule-2.2.6.ebuild:
....
src_unpack() {
        epatch "${FILESDIR}"/${P}-fallocate.diff
}
....

# ChangeLog for net-p2p/amule
# Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
# $Header: /var/cvsroot/gentoo-x86/net-p2p/amule/ChangeLog,v 1.150 2010/04/11 17:52:42 armin76 Exp $

  11 Apr 2010; Raúl Porcel <armin76@gentoo.org> amule-2.2.6.ebuild,
  +files/amule-2.2.6-fallocate.diff:
  Add patch from debian to build on hppa wrt #312831
==================================================

May be 
src_unpack() {
        default_src_unpack
        epatch "${FILESDIR}"/${P}-fallocate.diff
}
fix this mistake.

Comment 1 François Valenduc 2010-04-14 15:38:06 UTC

The error still occurs after adding default_src_unpack. Replacing src_unpack by src_prepare solves the problem.

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2010-04-16 14:14:17 UTC

Thanks for reporting. It's fixed now.