Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315037 - app-portage/gentoolkit-0.3.0_rc10-r1: euse fails when PORTDIR contains special characters
Summary: app-portage/gentoolkit-0.3.0_rc10-r1: euse fails when PORTDIR contains specia...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 19:26 UTC by Michał Górny
Modified: 2011-04-25 03:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The patch to fix the quoting of profilepath (partially) (euse-profilepath-quoting.diff,1.21 KB, patch)
2010-04-13 19:26 UTC, Michał Górny
Details | Diff
Re-implement the previous patch against the new 0.3.0 euse (euse-315037.patch,1.18 KB, patch)
2011-04-25 03:17 UTC, Jared Hancock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-04-13 19:26:00 UTC
The 'euse' script included within gentoolkit fails to work when PORTDIR path contains special characters. In fact, an attempt to use it results in the following error output:

$ LC_ALL=C euse 
egrep: ▲: No such file or directory
egrep: ▲: No such file or directory
egrep: ▲/profiles/default/linux/amd64/10.0/desktop/parent: No such file or directory
egrep: ▲: No such file or directory
egrep: ▲: No such file or directory
egrep: ▲/profiles/default/linux/amd64/10.0/desktop/parent: No such file or directory
ERROR: /usr/\n ▲ \n▲ ▲/profiles does not exist or is not a directory

The reason for that is lack of quoting in $() calls in get_all_make_defaults() / get_make_defaults(), for which I'm attaching a patch. However, afterwards script still fails to work due to the concept of returning multiple paths from get_all_make_defaults() as a scalar. As fixing this one would require a change in the concept, I'm not attaching a ready-made fix.

And, for the sake of formality, the output of 'euse' after applying my first patch:

$ LC_ALL=C ./euse
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/targets/desktop/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/releases/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/releases/10.0/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/features/multilib/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/arch/amd64/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/default/linux/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/base/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/targets/desktop/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/releases/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/releases/10.0/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/features/multilib/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/arch/amd64/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/default/linux/make.defaults: No such file or directory
./euse: line 272: source: /usr/: is a directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲: No such file or directory
./euse: line 272: ▲/profiles/base/make.defaults: No such file or directory
ERROR: /usr/\n ▲ \n▲ ▲/profiles does not exist or is not a directory

--
Portage  (default/linux/amd64/10.0/desktop, gcc-4.4.3, glibc-2.11-r1, 2.6.33-gentoo-r1-mgorny-amd64 x86_64)
=================================================================
System uname: Linux-2.6.33-gentoo-r1-mgorny-amd64-x86_64-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_3800+-with-gentoo-2.0.1
Timestamp of tree: Tue, 13 Apr 2010 16:45:03 +0000
app-shells/bash:     4.1_p5
dev-java/java-config: 2.1.10
dev-lang/python:     2.6.5-r1, 2.7_pre20100411, 3.1.2-r2, 3.2_pre20100411
dev-util/cmake:      2.8.1
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     9999
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.13, 2.65
sys-devel/automake:  1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1
sys-devel/gcc:       4.4.3
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6b
virtual/os-headers:  2.6.33
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/usr/local/portage/distfiles"
EMERGE_DEFAULT_OPTS="--ask --keep-going"
FEATURES="assume-digests collision-protect distlocks fixpackages news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="pl_PL.UTF-8"
LC_ALL="pl_PL.UTF-8"
LDFLAGS="-Wl,-O1"
LINGUAS=""
MAKEOPTS="-j3"
PKGDIR="/usr/local/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --times --compress --force --whole-file --delete --stats --timeout=45 --exclude=/distfiles --exclude=/packages --exclude=/local"
PORTAGE_TMPDIR="/tmp"
PORTDIR="/usr/
 ▲ 
▲ ▲"
PORTDIR_OVERLAY="/usr/local/portage/layman/x11 /usr/local/portage/layman/gamerlay /usr/local/portage/layman/science /usr/local/portage/layman/perl-experimental /usr/local/portage/layman/sunrise /usr/local/portage/layman/java-overlay /usr/local/portage/layman/games /usr/local/portage/layman/qting-edge /usr/local/portage/layman/python /usr/local/portage/layman/kde-sunset"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 avahi bash-completion bluetooth branding bzip2 cairo cdr cli consolekit cracklib crypt cups curl cxx dbus dirac directfb djvu dri dts dvd dvdr emboss encode exif expat fam fbcon fftw firefox flac fontconfig fortran gd gdbm gif gmp gnome-keyring gnutls gpm graphviz gtk iconv icu idn imagemagick ipv6 java6 jbig jpeg jpeg2k kate lapack lcms libedit libnotify libproxy mad matroska mikmod mmap mmx mmxext mng modules mp3 mp4 mpeg mtp mudflap multilib ncurses nptl nptlonly ogg opencore-amr openexr opengl openmp pam pango pch pcre pdf perl png ppds pppd python qt3support qt4 raw readline reflection schroedinger sdl session slang smp sndfile speex spell spl sse sse2 ssl ssse3 startup-notification svg sysfs tcpd theora threads tiff timidity truetype unicode usb v4l2 vcd vim-syntax vorbis wavpack wifi wmf x264 xcb xcomposite xml xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" RUBY_TARGETS="ruby18" SANE_BACKENDS="artec_eplus48u" USERLAND="GNU" VIDEO_CARDS="radeon vesa" 
Unset:  CPPFLAGS, CTARGET, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-04-13 19:26:27 UTC
Created attachment 227649 [details, diff]
The patch to fix the quoting of profilepath (partially)
Comment 2 Jared Hancock 2011-04-25 03:17:27 UTC
Created attachment 271061 [details, diff]
Re-implement the previous patch against the new 0.3.0 euse

I think I understand the issue with returning from a list traverse_profile() as a scalar. Can you verify that we're back to where you started with this patch?

I'll look at adapting the return value to a list. It will probably make the code more stable under more typical circumstances too.