Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 314951 - net-dialup/misdn-1.1.7: CFLAGS was changed ... Fix it to use EXTRA_CFLAGS.
Summary: net-dialup/misdn-1.1.7: CFLAGS was changed ... Fix it to use EXTRA_CFLAGS.
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 09:42 UTC by Florian Streibelt
Modified: 2013-02-10 08:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (misdn-1.1.7.2_build.log,271.27 KB, text/plain)
2010-04-13 09:43 UTC, Florian Streibelt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Streibelt 2010-04-13 09:42:04 UTC
# emerge -1 =net-dialup/misdn-1.1.7

...

 * Preparing mISDN_capi module
make -j3 HOSTCC=x86_64-pc-linux-gnu-gcc CROSS_COMPILE=x86_64-pc-linux-gnu- LDFLAGS= -C /usr/src/linux SUBDIRS=/var/tmp/portage/net-dialup/misdn-1.1.7/work/mISDN-1_1_7/drivers/isdn/hardware/mISDN MINCLUDES=/var/tmp/portage/net-dialup/misdn-1.1.7/work/mISDN-1_1_7/include CONFIG_MISDN_DRV=m CONFIG_MISDN_DSP=y CONFIG_MISDN_AVM_FRITZ=y CONFIG_MISDN_HFCPCI=y CONFIG_MISDN_HFCMULTI=y CONFIG_MISDN_HFCUSB=y CONFIG_MISDN_HFCMINI=y CONFIG_MISDN_XHFC=y CONFIG_MISDN_SPEEDFAX=y CONFIG_MISDN_W6692=y CONFIG_MISDN_NETJET=y modules
make: Entering directory `/usr/src/linux-2.6.33-gentoo'
scripts/Makefile.build:49: *** CFLAGS was changed in "/var/tmp/portage/net-dialup/misdn-1.1.7/work/mISDN-1_1_7/drivers/isdn/hardware/mISDN/Makefile". Fix it to use EXTRA_CFLAGS.  Stop.
make: *** [_module_/var/tmp/portage/net-dialup/misdn-1.1.7/work/mISDN-1_1_7/drivers/isdn/hardware/mISDN] Error 2
make: Leaving directory `/usr/src/linux-2.6.33-gentoo'
 * ERROR: net-dialup/misdn-1.1.7 failed:


Reproducible: Always

Steps to Reproduce:
Comment 1 Florian Streibelt 2010-04-13 09:42:29 UTC
$ emerge --info
Portage 2.1.8.3 (default/linux/amd64/10.0, gcc-4.4.3, glibc-2.11-r1, 2.6.33-gentoo x86_64)
=================================================================
System uname: Linux-2.6.33-gentoo-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T8300_@_2.40GHz-with-gentoo-2.0.1
Timestamp of tree: Mon, 12 Apr 2010 20:15:03 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:     4.1_p2-r1
dev-java/java-config: 2.1.10
dev-lang/python:     2.6.5-r1, 3.1.2-r1
dev-python/pycrypto: 2.1.0
dev-util/cmake:      2.8.1
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.1-r1
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.13, 2.65
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1
sys-devel/gcc:       4.3.4, 4.4.3
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6b
virtual/os-headers:  2.6.33
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests distlocks fixpackages news parallel-fetch protect-owned sandbox sfperms splitdebug strict unmerge-logs unmerge-orphans userfetch userpriv"
GENTOO_MIRRORS="http://de-mirror.org/distro/gentoo http://distfiles.gentoo.org http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LANG="de_DE.UTF8"
LC_ALL="de_DE.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en de"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--exclude=/metadata/kernel"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/rbu /usr/local/poverlay"
SYNC="rsync://ftp.spline.de/gentoo-portage"
USE="X acl acpi alsa amd64 avahi bash-completion berkdb bluetooth bzip2 cairo cli cracklib crypt cups cxx dbus dri fortran fuse gdbm gif gnome gpm gtk hal iconv iproute2 ipv6 jpeg laptop libnotify mmx modules mppe-mppc mudflap multilib nautilus ncurses nls nptl nptlonly obex offensive opengl openmp pam pcre perl png policykit pppd python qt3 qt3support qt4 readline reflection session spl sse sse2 ssl startup-notification svg sysfs tcpd threads tiff truetype unicode vorbis xinerama xorg xvmc zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="alias asis auth_basic auth_digest authn_alias authn_anon authn_default authn_file authz_default authz_groupfile authz_host authz_owner authz_user dav dav_fs dav_lock dir env expires headers include info log_config logio mime mime_magic negotiation rewrite setenvif unique_id vhost_alias  autoindex  proxy proxy_http proxy_ajp  status userdir" ELIBC="glibc" INPUT_DEVICES="evdev keyboard mouse synaptics joystick wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en de" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="nv svga nvidia" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS
Comment 2 Florian Streibelt 2010-04-13 09:43:49 UTC
Created attachment 227573 [details]
Build log
Comment 3 Florian Streibelt 2010-04-13 10:38:22 UTC
The problem is in
drivers/isdn/hardware/mISDN/Makefile.v2.6

this file gets copied over to drivers/isdn/hardware/mISDN/Makefile whenever one executes make.

in this file there are two lines at the top that change CFLAGS directly.
Comment 4 Rafał Mużyło 2010-04-13 19:11:48 UTC
So, a parallel make problem, right ?
Comment 5 Florian Streibelt 2010-04-18 18:59:35 UTC
(In reply to comment #4)
> So, a parallel make problem, right ?
> 

The Toplevel Makefile copies/renames a Makefile with every invokation  of make on the toplevel. So when you try to fix the Makefile in which the error actually happens, it gets overwritten when you try out the 'fix'.  

Just do a grep -r 'CFLAGS' in the source dir and you'll notice. 

The file .../misdn-1.1.7/work/mISDN-1_1_7/drivers/isdn/hardware/mISDN/Makefile is getting replaced every time you start make/try to emerge.

the lines:
  6 ifdef MINCLUDES
  7 CFLAGS += -I$(MINCLUDES) -g
  8 endif
should read:
  6 ifdef MINCLUDES
  7 EXTRA_CFLAGS += -I$(MINCLUDES) -g
  8 endif


The commandline
 MAKEOPTS="-j1" emerge -1 =net-dialup/misdn-1.1.7
fails too, so its not a parallel build problem, its an error in te files
mISDN/Makefile.v2.4 and mISDN/Makefile.v2.6


Comment 6 Pacho Ramos gentoo-dev 2013-02-10 08:01:23 UTC
dropped