Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 314823 - [x11 overlay] gentoo no-hardcoded-etc does not apply now
Summary: [x11 overlay] gentoo no-hardcoded-etc does not apply now
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 14:43 UTC by Cedric Godin
Modified: 2010-06-25 13:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Godin 2010-04-12 14:43:29 UTC
When trying to emerge xorg-server-9999 from overlay, I have:
 * GIT update -->
 *    repository:               git://anongit.freedesktop.org/git/xorg/xserver
 *    at the commit:            d7c98c1c81ae272f66edb05fde20f4c616604add
 *    branch:                   master
 *    storage directory:        "/usr/portage/distfiles/git-src/xorg-server"
 * Failed Patch: 1.8.0-no-hardcoded-etc.patch !
 *  ( /var/lib/layman/x11/x11-base/xorg-server/files/1.8.0-no-hardcoded-etc.patch )

That's because the Makefile.am doesn't match anymore the one in the patch:
from the live:
xorgconfddir = $(datadir)/X11/$(XF86CONFIGDIR)
xorgconfd_DATA = 10-evdev.conf

from the patch:
-xorgconfddir = $(prefix)/etc/X11/$(XF86CONFIGDIR)
+xorgconfddir = $(sysconfdir)/$(XF86CONFIGDIR)
 xorgconfd_DATA = 10-evdev.conf


Reproducible: Always
Comment 1 Cedric Godin 2010-04-12 15:02:20 UTC
BTW, I applied a the following simple patch and emerge tested it, don't know if it's correct:

diff --git a/x11-base/xorg-server/xorg-server-9999.ebuild b/x11-base/xorg-server/xorg-server-9999.ebuild
index f871089..b7d26a1 100644
--- a/x11-base/xorg-server/xorg-server-9999.ebuild
+++ b/x11-base/xorg-server/xorg-server-9999.ebuild
@@ -102,7 +102,6 @@ EPATCH_SUFFIX="patch"
 PATCHES=(
        "${UPSTREAMED_PATCHES[@]}"
        "${FILESDIR}"/${PN}-disable-acpi.patch
-       "${FILESDIR}"/1.8.0-no-hardcoded-etc.patch
        )
 
 pkg_setup() {
Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev 2010-04-12 16:57:43 UTC
Our patch differ from upstream changes and should be adjusted and still applied because their path handling is really weird.
Comment 3 Cedric Godin 2010-04-17 09:49:34 UTC
Is this bug still relevant or may we close it ?
Comment 4 inf3rn0 2010-05-02 19:59:16 UTC
(In reply to comment #3)
> Is this bug still relevant or may we close it ?
> 

Ran into this bug today - I did the following to 'fix':

Edit the patch in the overlay:
 # nano /usr/local/portage/layman/x11/x11-base/xorg-server/files/1.8.0-no-hardcoded-etc.patch

Replace the following line:
  -xorgconfddir = $(prefix)/etc/X11/$(XF86CONFIGDIR)

With:
  -xorgconfddir = $(datadir)/X11/$(XF86CONFIGDIR)

Save changes, then run:
  ebuild /usr/local/portage/layman/x11/x11-base/xorg-server/xorg-server-9999.ebuild digest

Then try merging again. Hope this helps anyone
Comment 5 Rémi Cardona (RETIRED) gentoo-dev 2010-06-25 13:33:32 UTC
Looks like Tómaš fixed this a couple weeks ago. Closing