Saving a game works fine. Trying to load a games gives "Fatal Error: First token isn't a brace" then shutsdown. It's apparently fixed in cvs, and seems trivial. Can you patch 0.5.4 with this fix? Reproducible: Always Steps to Reproduce: 1. Try to Load a game Actual Results: shutdown Expected Results: Continue shooting the hell outa evil monsters. none needed
Be sure to mention the name of the package in your bug reports. ;-)
oops :) I thought bugzilla would just know!
`emerge sync` in a bit and re-emerge quakeforge ... if you see a msg about patching with a com-parse patch, then you have the right version ... test it to make sure it fixes the bug then i'll ver bump the ebuild ;)
Calculating dependencies ...done! >>> emerge (1 of 1) games-fps/quakeforge-0.5.4 to / >>> md5 src_uri ;-) quakeforge-0.5.4.tar.bz2 >>> Unpacking source... >>> Unpacking quakeforge-0.5.4.tar.bz2 to /var/tmp/portage/quakeforge-0.5.4/work * Applying 0.5.4-com-parse.patch... * Failed Patch: 0.5.4-com-parse.patch! * * Include in your bugreport the contents of: * * /var/tmp/portage/quakeforge-0.5.4/temp/0.5.4-com-parse.patch-23995.out !!! ERROR: games-fps/quakeforge-0.5.4 failed. !!! Function epatch, Line 322, Exitcode 0 !!! Failed Patch: 0.5.4-com-parse.patch! cat /var/tmp/portage/quakeforge-0.5.4/temp/0.5.4-com-parse.patch-23995.out ***** 0.5.4-com-parse.patch ***** ================================= PATCH COMMAND: patch -g0 -p0 < /usr/portage/games-fps/quakeforge/files/0.5.4-com-parse.patch ================================= can't find file to patch at input line 3 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |--- quakeforge-0.5.4/libs/util/idparse.c 2003-05-26 15:14:18.000000000 -0400 |+++ quakeforge/libs/util/idparse.c 2003-07-27 18:00:25.000000000 -0400 -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored ================================= PATCH COMMAND: patch -g0 -p1 < /usr/portage/games-fps/quakeforge/files/0.5.4-com-parse.patch ================================= patching file libs/util/idparse.c Hunk #1 FAILED at 33. 1 out of 2 hunks FAILED -- saving rejects to file libs/util/idparse.c.rej ================================= PATCH COMMAND: patch -g0 -p2 < /usr/portage/games-fps/quakeforge/files/0.5.4-com-parse.patch ================================= can't find file to patch at input line 3 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |--- quakeforge-0.5.4/libs/util/idparse.c 2003-05-26 15:14:18.000000000 -0400 |+++ quakeforge/libs/util/idparse.c 2003-07-27 18:00:25.000000000 -0400 -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored ================================= PATCH COMMAND: patch -g0 -p3 < /usr/portage/games-fps/quakeforge/files/0.5.4-com-parse.patch ================================= can't find file to patch at input line 3 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |--- quakeforge-0.5.4/libs/util/idparse.c 2003-05-26 15:14:18.000000000 -0400 |+++ quakeforge/libs/util/idparse.c 2003-07-27 18:00:25.000000000 -0400 -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored ================================= PATCH COMMAND: patch -g0 -p4 < /usr/portage/games-fps/quakeforge/files/0.5.4-com-parse.patch ================================= missing header for unified diff at line 3 of patch can't find file to patch at input line 3 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |--- quakeforge-0.5.4/libs/util/idparse.c 2003-05-26 15:14:18.000000000 -0400 |+++ quakeforge/libs/util/idparse.c 2003-07-27 18:00:25.000000000 -0400 -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored ps, should the following two lines be in the patch for libs/util/idparse.c ? - "$Id: 0.5.4-com-parse.patch,v 1.1 2003/10/27 23:34:42 vapier Exp $"; + "$Id: 0.5.4-com-parse.patch,v 1.1 2003/10/27 23:34:42 vapier Exp $"; patching manually gives: Hunk #1 FAILED at 33 and gives the following .rej cat libs/util/idparse.c.rej *************** *** 33,39 **** #endif static __attribute__ ((unused)) const char rcsid[] = - "$Id: 0.5.4-com-parse.patch,v 1.1 2003/10/27 23:34:42 vapier Exp $"; #include <ctype.h> #include <stdlib.h> --- 33,39 ---- #endif static __attribute__ ((unused)) const char rcsid[] = + "$Id: 0.5.4-com-parse.patch,v 1.1 2003/10/27 23:34:42 vapier Exp $"; #include <ctype.h> #include <stdlib.h> but the important bit patches ok.
fixed in portage ... stupid cvs headers
Removing the first hunk of the patch fixes the epatch problem, and, more importantly, fixes loading games! Thanks :) working 0.5.4-com-parse.patch below --- quakeforge-0.5.4/libs/util/idparse.c 2003-05-26 15:14:18.000000000 -0400 +++ quakeforge/libs/util/idparse.c 2003-07-27 18:00:25.000000000 -0400 @@ -107,8 +107,11 @@ skipwhite: while (isspace ((byte) *data)) data++; - if (!*data) + if (!*data) { + dstring_clearstr (_com_token); + com_token = _com_token->str; return 0; + } if (data[0] == '/' && data[1] == '/') { while (*data && *data != '\n') data++;
sounds good :)
