expect 5.44 has been recalled, see <http://expect.nist.gov/>. It was recalled early 2006: <http://linuxfromscratch.org/pipermail/lfs-dev/2006-February/055752.html>, and yes, this applies to 5.44.1 as well: <http://www.mail-archive.com/lfs-book@linuxfromscratch.org/msg08097.html>. Ignoring any possible other reasons, the configure script has a clear syntax error, which causes the build to fail depending on your /bin/sh. bash happens to ignore it, but with dash I get checking system version (for dynamic loading)... ./configure: 1: Syntax error: Unterminated quoted string !!! Please attach the following file when seeking support: !!! /var/tmp/portage/dev-tcltk/expect-5.44.1/work/expect-5.44.1/config.log due to system=MP-RAS-`awk '{print }' /etc/.relid'` where no apostrophe belongs after relid.
Do you really want to have it removed or should I patch the error?
If you know the reasons why it was recalled and you're sure that they don't apply to Gentoo, then by all means patch this one thing and keep it in the tree, but otherwise I think it would be best to drop it.
I thought it would be just the quoting problem, so I removed it.
Sorry to comment on a resolved bug, but is expect-5.44.1.15 still in recall status? It appears to have more than 2 years of development over past when 5.44.1 was released. On a quick glance over, it at least fixes the quoting bug in the configure script and a lot of the more serious problems (buffer overflows, memory leaks, etc), but I don't know what version 5.44 was recalled for in the first place so I don't know if it's out of "recalled" status yet. You can find the tarballs on the project's sourceforge site [1]. [1] http://sourceforge.net/projects/expect/files/
I will reopen the. Please clarify, if this version is in a shape that we can pack it. Then I will add the bump to the tree.
(In reply to comment #5) > I will reopen the. Please clarify, if this version is in a shape that we can > pack it. Then I will add the bump to the tree. The newest version looks like it fixes the problems people were having with 5.44 and 5.44.1, but I'm not an upstream developer. Anyway, I've opened bug #314033 with ebuild updates and an updated patch attached.
*** Bug 314033 has been marked as a duplicate of this bug. ***
(In reply to comment #7) > *** Bug 314033 has been marked as a duplicate of this bug. *** Well, at least pull the patches from that bug then. :)
I commented on the other bug. :)
Created attachment 227083 [details, diff] Ebuild updates for expect-5.44.1.15 Ebuild updates for expect-5.44.1.15: * Update SRC_URI to use the bzip2 tarball from sourceforge * Remove test restriction -- test suite passes all 29 test successfully for me * No need to copy in expect.m4 file anymore since it's included * Remove sed calls since the test suite works now and the correct tcl header is included * DESTDIR patch applied upstream so it's no longer necessary * Apply patches to fix FreeBSD and LDFLAGS issues -- note that the FreeBSD patch has been updated from the one applied to the previous 5.44.1 version while the LDFLAGS patch is the same applied to the removed 5.44.1 version * Use emake to build the tests correctly * Remove old code that removes a now nonexistent static lib
Created attachment 227085 [details, diff] expect-5.44.1.15-gfbsd.patch Updated FreeBSD patch for expect-5.44.1.15
(In reply to comment #9) > I commented on the other bug. :) No problem, I've transferred the patches/comments to this bug.
Note that the ebuild update patch is from the most recent 5.44.1 ebuild that was in the tree for about 6 days before being removed recently as per bug #313567.
(In reply to comment #5 and comment #6) Well, the recall definitely doesn't apply to 5.44.1.15. The 5.44.1.x files are essentially development snapshots, but they have been picked up by at least Debian, FreeBSD, Fedora, and Arch already, so they are probably fine to add.
Thanks for spending time looking into that. I will add them soon.
+*expect-5.44.1.15 (12 Apr 2010) + + 12 Apr 2010; Justin Lecher <jlec@gentoo.org> +expect-5.44.1.15.ebuild, + +files/expect-5.44.1.15-gfbsd.patch, + +files/expect-5.44.1.15-ldflags.patch, -files/expect-5.44.1-ldflags.patch: + Version Bump, per 313567, thanks Harald van Dijk for patches +
Thanks. One nit: it's Tim Harder who submitted the patches, not me.
Sorry Tim, that wasn't intended. I just took the reporter. :)
(In reply to comment #18) > Sorry Tim, that wasn't intended. I just took the reporter. :) No problem, thanks for getting it in the tree.
