Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 31244 - net-analyzer/nsat ebuilds broken
Summary: net-analyzer/nsat ebuilds broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Daniel Ahlberg (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-16 00:34 UTC by Ciaran McCreesh
Modified: 2003-10-28 05:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild (nsat-1.50-r1.ebuild,1.32 KB, text/plain)
2003-10-16 00:35 UTC, Ciaran McCreesh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ciaran McCreesh 2003-10-16 00:34:33 UTC
The net-analyzer/nsat ebuilds are severely broken. I get the impression that they weren't tested before they were added to the portage tree...

1) The version numbers are wrong. The latest version is 1.5, which uses nsat-1.5.ebuild . There is also an older version, 1.43, which is in portage as nsat-1.43.ebuild. Because of the way portage handles version numbers (the Linux way rather than the Windows way), 1.43 is seen as being later than 1.5, which is incorrect.

2) The dependency upon libpcap is incorrect. If I try `USE="-*" emerge =nsat-1.5` I get the following error:

g++ -Wall -O6 -funroll-loops -ansi -fPIC -DLINUX -c xp_icmp_addrmask.c
In file included from xp_icmp_addrmask.c:24:
xprobe.h:85:18: pcap.h: No such file or directory
make[2]: *** [xp_icmp_addrmask.o] Error 1
make[2]: Leaving directory `/var/tmp/portage/nsat-1.5/work/nsat/src/mod'
make[1]: *** [modobj] Error 2
make[1]: Leaving directory `/var/tmp/portage/nsat-1.5/work/nsat/src'
make: *** [all] Error 2

The header pcap.h is provided by libpcap. libpcap should *always* be required, regardless of whether USE="pcap" is set.

3) If X support is included, xnsat will not run without 'wish'. This is provided by 'dev-lang/tk', which needs to be added to the DEPEND.

4) xnsat won't run without some editing. This is because portage doesn't install to the path that the Makefile expects. The only way around this is to do some sed magic on Makefile.in, tools/xnsat and src/lang.h (the --prefix configure option isn't honoured).

5) the ebuilds install the configuration file into /etc/nsat/nsat.conf . Some more sed magic is needed on src/lang.h to make nsat look there rather than in /usr/local/share/nsat/ .

I'm attaching an ebuild which fixes these issues. I suggest it be named net-analyzer/nsat/nsat-1.50-r1.ebuild as this is will fix the version number issue.

I've also added the sparc keyword as this app runs fine on Sun kit.
Comment 1 Ciaran McCreesh 2003-10-16 00:35:21 UTC
Created attachment 19299 [details]
new ebuild
Comment 2 Daniel Ahlberg (RETIRED) gentoo-dev 2003-10-28 05:40:12 UTC
I fixed all the errors + some I found. I simply removed the 1.43 ebuild so
that 1.5 would be found.

Thanks for your contribution!