Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 312369 - sci-chemistry/rasmol-2.7.5: ebuild is incorrect
Summary: sci-chemistry/rasmol-2.7.5: ebuild is incorrect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Justin Lecher (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 11:57 UTC by Rafał Mużyło
Modified: 2010-03-31 20:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix for bundled libs (rasmol-no-bundled-libs.patch,250 bytes, patch)
2010-03-31 11:58 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2010-03-31 11:57:12 UTC
First of all, unless I'm missing something it's
either xforms or gtk+, so having both in RDEPEND is wrong.
Second, while I'm not 100% sure it's correct, passing
LDFLAGS through LDOPTIONS to emake seems to work without
additional patching.

Finally, it seems (on x86, not 100% sure about prefix),
that a much simpler patch for bundled libs works.
I'll attach it. I reversed the order - I'm patching Imakefile_base first,
then rename it.
(AFAICT, there's no point in patching
Makefile.in, as nothing seems to use it)
Comment 1 Rafał Mużyło 2010-03-31 11:58:20 UTC
Created attachment 225929 [details, diff]
fix for bundled libs
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2010-03-31 12:10:28 UTC
You are right, xforms is a leftover from old versions.

The LDFLAGS/LDOPTIONS things depends, what LDOPTIOSN are used for.
I will lookinto that.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2010-03-31 20:44:10 UTC
Fixed Thanks for reporting