Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 31191 - Patch for lame 3.93.1 to let it build with stricter compilers
Summary: Patch for lame 3.93.1 to let it build with stricter compilers
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-15 05:35 UTC by Spider (RETIRED)
Modified: 2004-01-21 10:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
(int) casting case (lame-3.93.1-tcc.patch,433 bytes, patch)
2003-10-15 05:36 UTC, Spider (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Spider (RETIRED) gentoo-dev 2003-10-15 05:35:55 UTC
very simple casting case that has to be patched in order to build lame with tcc.


Reproducible: Always
Steps to Reproduce:




attaching a patch below. It should be no-nonsense and I'm going to push it
upstream too.
Comment 1 Spider (RETIRED) gentoo-dev 2003-10-15 05:36:36 UTC
Created attachment 19265 [details, diff]
(int) casting case

Here it is
Comment 2 Nick Hadaway 2004-01-21 09:11:38 UTC
looks simple enough... gcc-3.3.2 doesn't seem to have a problem with it which surprises me... so... pointer... to integer... without a cast...

I just checked in lame-3.95.1 which has the same block of code without the int declaration.  Spider, shall I add the patch into all lame versions in portage?
Comment 3 Spider (RETIRED) gentoo-dev 2004-01-21 09:20:46 UTC
it'd be nice if you did, aye.

amusing fact though, lame performs about equal between the two, though only due to lame being asm optimized already as tcc doesn't have any architecture specific optimizations, nor many others..  However its fast ;)
Comment 4 Nick Hadaway 2004-01-21 10:59:47 UTC
added to 3.95.1... please test... also make sure you see the mlame binary showing up and working correctly if you would. :)