Bug 311759 – sys-apps/grep-2.6.1 null pointer reference when using --include or --exclude

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Javier Villavicencio (RETIRED) 2010-03-28 15:13:28 UTC]

Bug seems to be a typo in savedir.c, the fix on upstream's git makes the segfault go away, however --include isn't working.

http://git.savannah.gnu.org/cgit/grep.git/commit/?id=54d55bba41f2ff31682fe6523ef6f49b37a0e20f

[Comment 1 Javier Villavicencio (RETIRED) 2010-03-28 17:58:14 UTC]

Created attachment 225587 [details, diff]
Proposed patch.

Please take a look / test this patch if possible before I attach it to the upstream bug report.

[Comment 2 Javier Villavicencio (RETIRED) 2010-03-28 21:16:07 UTC]

Fix got split, a gnulib patch to exclude.c and a grep patch to main.c and lib/savedir.c

They are upstream with a bunch of new tests added:

grep:
savedir.c #1: http://git.savannah.gnu.org/cgit/grep.git/commit/?id=54d55bba41f2ff31682fe6523ef6f49b37a0e20f
savedir.c #2: http://git.savannah.gnu.org/cgit/grep.git/commit/?id=da3d9ebff4400a131448b1548bc5e12d8e701ae3
main.c: http://git.savannah.gnu.org/cgit/grep.git/commit/?id=d0d99971ff63d861d32e83d49eb399c3519a2542

gnulib:
exclude.c: http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=6207255863f1fb5172ead8b03cda5e4b0b7336a4

[Comment 3 SpanKY 2010-03-29 04:51:23 UTC]

i wasnt going to worry too much about adding fixes for 2.6.1 since there was indication that a new version was going to be put out to address these things (i guess there's more bugs too)

[Comment 4 Javier Villavicencio (RETIRED) 2010-03-29 11:07:08 UTC]

This one in particular. it's killing me,

http://sources.gentoo.org/viewcvs.py/gentoo-x86/profiles/default/bsd/profile.bashrc?rev=1.3&view=markup

>_<

[Comment 5 SpanKY 2010-03-29 17:33:52 UTC]

i didnt think people really used that option.  oh well.

2.6.2 should be out in a day or two, so if you dont mind just waiting ...

[Comment 6 Javier Villavicencio (RETIRED) 2010-03-29 17:42:58 UTC]

Fair enough.