Bug 311737 – devmanual should be more clear on usage of MY_PV

• Status: RESOLVED FIXED
• Product: Documentation

[Description Justin Lecher (RETIRED) 2010-03-28 11:38:37 UTC]

The manual says

For example, what Gentoo calls foo-1.2.3b may be expecting a tarball named foo-1.2-3b.tar.bz2. Rather than hard coding version numbers, it is preferable to make a MY_PV variable and use that.

It might confuse, that it is _PV and has the complete P string in it.
Better subdivide that in MY_PN, MY_PV and MY_P.

[Comment 1 Petteri Räty (RETIRED) 2010-03-28 12:41:49 UTC]

I don't see anything wrong with the text. MY_PV in the example will not have complete P in it. Would it help if the example code had SRC_URI too? If you want to suggest a patch yourself the sources are at:
git+ssh://git.gentoo.org/var/gitroot/devmanual.git

[Comment 2 Justin Lecher (RETIRED) 2010-03-28 13:32:39 UTC]

Created attachment 225565 [details]
0001-bug-311737.patch

I thought about something like this

[Comment 3 Petteri Räty (RETIRED) 2010-03-28 13:46:00 UTC]

(In reply to comment #2)
> Created an attachment (id=225565) [details]
> 0001-bug-311737.patch
> 
> I thought about something like this
> 

* I don't think the committer needs (jlec) as the email has it
* packge
* loose the a in: make a <c>MY_PN</c> 
* & --> and
* in general the content is ok by me

[Comment 4 Justin Lecher (RETIRED) 2010-03-28 13:53:01 UTC]

Created attachment 225567 [details]
0002-Reviewed-changes.patch

The changes proposed

[Comment 5 Justin Lecher (RETIRED) 2010-03-28 13:54:07 UTC]

(In reply to comment #3)
> * I don't think the committer needs (jlec) as the email has it
> * packge
??

[Comment 6 Justin Lecher (RETIRED) 2010-03-28 13:58:10 UTC]

Created attachment 225569 [details]
0003-packge-package.patch

Last fix

[Comment 7 Petteri Räty (RETIRED) 2010-03-28 14:22:36 UTC]

Pushed after combining commits and fixing redefing to redefining. Thanks for the contribution.