Bug 311145 – New ebuild for xfce4-hdaps-0.0.5

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michael Orlitzky 2010-03-24 16:24:40 UTC]

Yeah, I'm the author. But Debian has it, and they can't have it if we don't. I'm attaching the ebuild I've been using in my overlay.

[Comment 1 Michael Orlitzky 2010-03-24 16:25:11 UTC]

Created attachment 225119 [details]
Ebuild for xfce4-hdaps-0.0.5.ebuild

[Comment 2 Jeremy Olexa (darkside) (RETIRED) 2010-03-24 16:29:03 UTC]

Hi, I would recommend adding a kernel check for 2.6.28 and warning if something older is being used.

[Comment 3 Michael Orlitzky 2010-03-24 16:46:26 UTC]

Is there a way to *require* (greater than or equal to) a specific kernel version? HDAPSD already spits out a warning in pkg_postinst(), but the user is free to ignore it and render the daemon (and plugin) useless.

[Comment 4 Samuli Suominen (RETIRED) 2010-03-24 16:48:58 UTC]

(In reply to comment #3)
> Is there a way to *require* (greater than or equal to) a specific kernel
> version? HDAPSD already spits out a warning in pkg_postinst(), but the user is
> free to ignore it and render the daemon (and plugin) useless.
> 

linux-info.eclass

if kernel_is lt 2 6 28; then
echo "do something"
fi

[Comment 5 Samuli Suominen (RETIRED) 2010-03-24 16:50:53 UTC]

hint,

emerge eclass-manpages
man 5 linux-info.eclass
less /usr/portage/eclass/linux-info.eclass

[Comment 6 Michael Orlitzky 2010-03-24 17:05:32 UTC]

Yep, that's what HDAPSD is doing. I suppose it's the correct approach, since a newer kernel is really a run-time dependency. I'll re-echo it in my pkg_postinst().

[Comment 7 Samuli Suominen (RETIRED) 2010-03-24 17:12:30 UTC]

Created attachment 225129 [details]
ebuild

how about this? added missing depends, linux-info usage, debug use flag, ...

[Comment 8 Michael Orlitzky 2010-03-24 18:03:08 UTC]

Looks good to me. A warning might be more appropriate than an error for the kernel version, but everything else is definitely an improvement.

[Comment 9 Samuli Suominen (RETIRED) 2010-03-24 18:12:35 UTC]

Changed to warning, and committed.

Too bad the package is still using the obsolete libxfcegui4... should be using libxfce4ui, but that's another story.

thanks!

[Comment 10 Michael Orlitzky 2010-03-24 18:15:51 UTC]

I'll email the author and see if I can get that fixed...