Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 310253 - Please review Prefix changes for net-voip/linphone
Summary: Please review Prefix changes for net-voip/linphone
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Mounir Lamouri (volkmar) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 16:25 UTC by Fabian Groffen
Modified: 2010-03-21 12:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2010-03-19 16:25:25 UTC
--- linphone-3.2.1-r1.ebuild      2010-03-18 07:04:09 +0100
+++ linphone-3.2.1-r1.ebuild    2010-03-19 17:23:53 +0100
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/net-voip/linphone/linphone-3.2.1-r1.ebuild,v 1.1 2010/03/18 06:04:09 pva Exp $
 
-EAPI="2"
+EAPI="3"
 
 inherit eutils autotools multilib
 
@@ -81,7 +81,7 @@
        # rsvp: breaking the build (not maintained anymore) --disable = --enable
        # alsa, artsc and portaudio are used for bundled mediastreamer
        econf \
-               --libdir=/usr/$(get_libdir) \
+               --libdir="${EPREFIX}"/usr/$(get_libdir) \
                --disable-strict \
                --enable-external-ortp \
                --enable-external-mediastreamer \


Please accept or comment on the intended changes, thanks.
Comment 1 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev 2010-03-20 12:57:16 UTC
Feel free to commit this change without bumping the ebuild.
In the future, do not ask for only adding EPREFIX. The only issue I can see with this is for further stabilization (because of EAPI-3) and in that case I will move your changes to a -rX ebuild.

Thanks for your work guys !
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-20 13:53:27 UTC
(In reply to comment #1)

> with this is for further stabilization (because of EAPI-3) and in that case I

For the record, EAPI3 can be stabilized now. portage-2.1.7.17 (stable) supports it. Not sure if you knew that or not. :)
Comment 3 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev 2010-03-20 14:10:41 UTC
(In reply to comment #2)
> (In reply to comment #1)
> 
> > with this is for further stabilization (because of EAPI-3) and in that case I
> 
> For the record, EAPI3 can be stabilized now. portage-2.1.7.17 (stable) supports
> it. Not sure if you knew that or not. :)
> 

I didn't know that. I am not following gentoo-dev since a long time, too busy at work. Thanks for the information :)
Comment 4 Fabian Groffen gentoo-dev 2010-03-21 12:17:15 UTC
committed, thanks!