Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 30958 - new functionality for aterm
Summary: new functionality for aterm
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Aron Griffis (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-12 03:21 UTC by Michal Januszewski (RETIRED)
Modified: 2004-01-17 10:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
the patch for aterm-0.4.2 (aterm-0.4.2-paste_and_copy.patch,6.21 KB, patch)
2003-10-12 03:22 UTC, Michal Januszewski (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Januszewski (RETIRED) gentoo-dev 2003-10-12 03:21:27 UTC
Here is a patch for aterm-0.4.2 that I made a few days ago. It:
- fixes pasting non-ASCII characters (if you copy a text from Mozilla or similar app and then paste it in an aterm window, you'll get &{5145} or smth like it instead of ISO-8895-2/any other charset specific chars)
- makes it possible to copy text from an aterm window to XA_CLIPBOARD by pressing the ALT key while making a selection (if the ALT key is not pressed, the text is copied to XA_PRIMARY, as usual)
- incorporates the patch from bug #29232

I think it would be nice to have it included in Portage. The non-ASCII chars pasting problem can be really annoying, and I'm sure people will find the other fixes and features useful as well :)
Comment 1 Michal Januszewski (RETIRED) gentoo-dev 2003-10-12 03:22:10 UTC
Created attachment 19126 [details, diff]
the patch for aterm-0.4.2
Comment 2 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-10-12 06:27:47 UTC
I have no problem about copy&pasting from/to mozilla with aterm.
This is probably because I emerged aterm with USE="cjk", so
could you check it please, nakano?
Comment 3 Michal Januszewski (RETIRED) gentoo-dev 2003-10-12 16:24:07 UTC
It would seem so. aterm-0.4.2-ja patch makes aterm paste text as XA_COMPOUND_TEXT
and not as XA_STRING. XA_STRING is fine for us-ascii, but it's not enough
for other charsets.

Please note that my patch will most likely not work with aterm-0.4.2-ja,
so if it were to be included in the ebuild, it should be done in a one-or-the-other
manner (ie. if cjk is in USE, then apply aterm-0.4.2-ja, if not - apply the
other patch).
Comment 4 Aron Griffis (RETIRED) gentoo-dev 2004-01-15 07:45:22 UTC
Michal, I've committed the patch from bug 29232 since it applies equally to cjk and -cjk.  Would you mind removing that from your patch?  Additionally it sounds like your ALT patch would be helpful for cjk/-cjk, but the non-ASCII patch is only useful for -cjk.  If you would split that up so that the functionality isn't diverging so radically between cjk/-cjk, that would grease the skids to get this in finally.  Thanks.
Comment 5 Michal Januszewski (RETIRED) gentoo-dev 2004-01-17 10:05:17 UTC
Patches added to aterm-0.4.2-r7.