Emerging alsa-driver fails, with the following error: In file included from au8810_core.c:2: au88x0_core.c: In function `vortex_adb_allocroute': au88x0_core.c:1780: error: incompatible type for argument 1 of `spin_lock' au88x0_core.c:1887: error: incompatible type for argument 1 of `spin_unlock' make[2]: *** [au8810_core.o] Error 1 make[2]: Leaving directory `/var/tmp/portage/alsa-driver-0.9.7-r2/work/alsa-driver-0.9.7b/pci/au88x0' make[1]: *** [_modsubdir_au88x0] Error 2 make[1]: Leaving directory `/var/tmp/portage/alsa-driver-0.9.7-r2/work/alsa-driver-0.9.7b/pci' make: *** [compile] Error 1 This is using vanilla kernel 2.4.22 on Gentoo 1.4. The configure and patching go fine, then it just bombs on that file. GCC 3.3.1-r4 (I'm running ~x86). Reproducible: Always Steps to Reproduce: 1. Use a system running ~x86 with gcc 3.3.1-r2 and vanilla kernel 2.4.22. 2. Emerge alsa-driver Actual Results: Compile problem as above. Expected Results: Successful compile. This patch fixes the problem for me. It seems to be consistent with spin_lock() and spin_unlock() calls made elsewhere in the code: diff -ruN alsa-driver-0.9.7b.orig/pci/au88x0/au88x0_core.c alsa-driver-0.9.7b/pci/au88x0/au88x0_core.c --- alsa-driver-0.9.7b.orig/pci/au88x0/au88x0_core.c 2003-10-06 10:01:04.000000000 -0400 +++ alsa-driver-0.9.7b/pci/au88x0/au88x0_core.c 2003-10-12 00:59:47.000000000 -0400 @@ -1777,7 +1777,7 @@ if ((nr_ch == 3) || ((dir == SNDRV_PCM_STREAM_CAPTURE)&&(nr_ch > 2))) return -EBUSY; - spin_lock(vortex->lock); + spin_lock(&vortex->lock); if (dma >= 0) { en = 0; vortex_adb_checkinout(vortex, vortex->dma_adb[dma].resources, en, VORTEX_RESOURCE_DMA); @@ -1884,7 +1884,7 @@ } } vortex->dma_adb[dma].nr_ch = nr_ch; - spin_unlock(vortex->lock); + spin_unlock(&vortex->lock); #if 0 /* AC97 Codec channel setup. FIXME: this has no effect !! */
is this fixed with 0.9.8 ?
closing with 0.9.8
