Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 309147 - please remove sys-apps/busybox from virtual/editor
Summary: please remove sys-apps/busybox from virtual/editor
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-12 15:24 UTC by Jeremy Olexa (darkside) (RETIRED)
Modified: 2010-03-13 19:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-12 15:24:05 UTC
Feel free to change the assignment to others. I'm not sure if the metadata is correct in this case.

The addition of sys-apps/busybox to virtual/editor is not a good solution. While it is a valid editor, I agree, it has at least three flaws with it being in virtual/editor and they are all concerning the fact that busybox is in @system.

1) There is no need to have an editor explicitly listed in the world file because virtual/editor is in the @system set. This means that a --depclean will remove the user's editor.

2) The addition of busybox makes ROOT=foo emerge -e system diverge *away* from default stage3 installations (because there is no nano installed)

3) busybox is for power users, a person new to Linux will not know about "busybox vi <file>" - We should strive to be friendly to new users.
Comment 1 Ben de Groot (RETIRED) gentoo-dev 2010-03-12 15:32:03 UTC
It can be replaced by app-admin/eselect-vi (while this does not depend on any implementation, there will always be the busybox one, as it is in system set).
Comment 2 Ulrich Müller gentoo-dev 2010-03-12 16:00:33 UTC
(In reply to comment #1)
> It can be replaced by app-admin/eselect-vi (while this does not depend on any
> implementation, there will always be the busybox one, as it is in system set).

That wouldn't help, because busybox doesn't call eselect-vi, so the symlink doesn't get set without user interaction. I also think that it's conceptually wrong to have eselect modules in virtual/editor.

We should simply remove busybox from the virtual. Advanced users that want bb as their only editor can put virtual/editor in their package.provided.

Alternative solution: Add a "vi-symlink" USE flag to sys-apps/busybox, depend on "vi-symlink? ( app-admin/eselect-vi )" and call "use vi-symlink && eselect vi update --if-unset" in pkg_post{inst,rm}. Then virtual/editor could depend on "sys-apps/busybox[vi-symlink]". (But IMHO, that would be a lot of effort for very little return.)

Reassigning to emacs (de-facto maintainers of virtual/editor) and adding embedded (busybox maintainers) to CC.
Comment 3 Ulrich Müller gentoo-dev 2010-03-13 19:48:27 UTC
I've removed busybox from the dependencies of virtual/editor.