Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 308609 - dev-libs/glib-2.22.4 checks for 'perl5' which could induce failure for Gentoo Prefix systems
Summary: dev-libs/glib-2.22.4 checks for 'perl5' which could induce failure for Gentoo...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308455
  Show dependency tree
 
Reported: 2010-03-09 08:57 UTC by Stuart Shelton
Modified: 2010-04-03 16:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Shelton 2010-03-09 08:57:49 UTC
>>> Completed installing glib-2.22.4 into /usr/opt/portage/var/tmp/portage/dev-libs/glib-2.22.4/image/opt/portage/

 * automatically removing charset.alias
ecompressdir: bzip2 -9 /opt/portage/usr/share/man
removing executable bit: opt/portage/usr/lib/libgio-2.0.la
removing executable bit: opt/portage/usr/lib/libglib-2.0.la
removing executable bit: opt/portage/usr/lib/libgmodule-2.0.la
removing executable bit: opt/portage/usr/lib/libgobject-2.0.la
removing executable bit: opt/portage/usr/lib/libgthread-2.0.la
 * prefixing shebang of opt/portage/usr/bin/glib-gettextize
 * prefixing shebang of opt/portage/usr/share/glib-2.0/gettext/mkinstalldirs
 * QA Notice: the following files use invalid (possible non-prefixed) shebangs:
 * opt/portage/usr/bin/glib-mkenums:/usr/bin/perl5
 * ERROR: dev-libs/glib-2.22.4 failed:
 *   Aborting due to QA concerns: invalid shebangs found
 * 
 * Call stack:
 *   misc-functions.sh, line 1480:  Called install_qa_check
 *   misc-functions.sh, line   94:  Called install_qa_check_prefix
 *   misc-functions.sh, line  649:  Called die
 * The specific snippet of code:
 *              die "Aborting due to QA concerns: invalid shebangs found"
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-16 16:48:16 UTC
It works for me, for some reason.

%% head usr/bin/glib-mkenums
#!/home/jolexa/portage/linux-64/usr/bin/perl -w

Do you have /usr/bin/perl5 or something?
Comment 2 Stuart Shelton 2010-03-16 17:21:55 UTC
(Please note that this bug occured on prefix/IRIX)

Good thinking - between filing this bug and now, I realised that I did have an old $EPREFIX/usr/bin/perl5 link, pointing to a version of perl which is no longer present.

However, when I removed this I found that some builds failed *without* $EPREFIX/usr/bin/perl5 existing - so I simply re-linked it to './perl'.

(This assumption that perl5 exists may, of course, be because at some point it did exist on this system, and some builds started to use it preferentially)
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-16 17:29:41 UTC
Well there is your problem then. If you have perl5 in your path..it is preferred. I don't think we should fix this because dev-lang/perl does not install the perl5 symlink. You are just being hit by a more strict QA check than before.

%% pwd
/home/jolexa/portage/linux-64/var/tmp/portage/dev-libs/glib-2.22.4/work/glib-2.22.4
%% grep -r perl5 *
configure:for ac_prog in perl5 perl
configure.in:AC_CHECK_PROGS(PERL, [perl5 perl])
%%
Comment 4 Fabian Groffen gentoo-dev 2010-03-16 17:32:11 UTC
well, the nasty thing of that configure check is that if you have perl5 in /usr/bin, it will find it before your Prefix version.  I suggest we sed "perl perl5" -> "perl".
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-16 17:48:50 UTC
(In reply to comment #4)
> well, the nasty thing of that configure check is that if you have perl5 in
> /usr/bin, it will find it before your Prefix version.  I suggest we sed "perl
> perl5" -> "perl".
> 

Oh, that is nasty. I forgot that it would check for perl5 first. If you are suggesting to do something like a sed statement, then maybe we should use the upstream provided "way" to override the configure test. "PERL=$EPREFIX/usr/bin/perl econf ..." (untested)
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-22 14:42:02 UTC
FYI: I have just been informed that MacPorts installs "perl5" too.
Comment 7 Fabian Groffen gentoo-dev 2010-04-03 12:27:58 UTC
I committed darkside's suggested fix that should do it.