Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 308463 - x11-wm/awesome - window manager should close all applications before exiting
Summary: x11-wm/awesome - window manager should close all applications before exiting
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Maxim Koltsov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-08 14:03 UTC by Adam
Modified: 2013-02-06 13:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to implement closing of windows before quitting awesome (rc.lua.patch,212 bytes, patch)
2010-03-08 14:04 UTC, Adam
Details | Diff
Patch to attempt to implement requested functionality (rc.lua.patch,214 bytes, patch)
2010-03-08 14:13 UTC, Adam
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam 2010-03-08 14:03:57 UTC
In the default rc.lua configuration file that's installed with the awesome window manager (x11-wm/awesome-3.3.4), there's an option to quit the window manager.  When you do, all windows are forced-closed, which means if you were editing a text file and had unsaved changes, etc., these changes would be lost.  I think it would be nicer if the window manager attempted to close each window first, just as if the window had been closed manually, so that if the app wants to ask the user for confirmation before exiting, it can.

This is fairly simple to implement, and I've done so, and shall attach a patch to the rc.lua config file in a minute or so.


Reproducible: Always
Comment 1 Adam 2010-03-08 14:04:47 UTC
Created attachment 222653 [details, diff]
Patch to implement closing of windows before quitting awesome
Comment 2 Adam 2010-03-08 14:06:18 UTC
I forgot to mention - I'm not sure whether the rc.lua config file is created by Gentoo, or is the one provided by Awesome itself.  If the latter, I'd be fine with submitting the request to its creators instead of Gentoo.
Comment 3 Adam 2010-03-08 14:13:14 UTC
Created attachment 222657 [details, diff]
Patch to attempt to implement requested functionality

Sorry, that first patch didn't even compile.  Here's a new one that does.  It turns out it isn't that simple to implement either - the c:kill() line doesn't wait for the client to be killed.  If I can figure out a way to make this work, I'll submit an actual working patch...
Comment 4 MATSUU Takuto (RETIRED) gentoo-dev 2010-03-09 05:26:41 UTC
please report to upstream
Comment 6 Nikolaj Šujskij 2013-02-06 12:41:17 UTC
(In reply to comment #5)
> Done:
> 
> http://awesome.naquadah.org/bugs/index.php?do=details&task_id=738

RESOLVED UPSTREAM, I'd say. Or RESOLVED UPSTREAM WONTFIX :)
Using x11-misc/wmctrl is probably the best solution.
Comment 7 Denis M. (Phr33d0m) 2013-02-06 13:04:05 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Done:
> > 
> > http://awesome.naquadah.org/bugs/index.php?do=details&task_id=738
> 
> RESOLVED UPSTREAM, I'd say. Or RESOLVED UPSTREAM WONTFIX :)
> Using x11-misc/wmctrl is probably the best solution.

Correct. Upstream has marked this as WONTFIX there:
>Closed by  Uli Schlachter (psychon)
>Sunday, 15 August 2010, 19:16 GMT+1
>Reason for closing:  Won't implement
>Additional comments about closing:  It's not the window manager's job to kill apps.

So marking here as CANTFIX.