Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 306981 - version bump request: net-mail/topal-72
Summary: version bump request: net-mail/topal-72
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement
Assignee: Torsten Veller (RETIRED)
URL: http://homepage.ntlworld.com/phil.bro...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-26 18:05 UTC by Peter Gantner (a.k.a. nephros)
Modified: 2010-03-05 14:09 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated Makefile patch (72-Makefile.patch,1.42 KB, patch)
2010-02-26 18:08 UTC, Peter Gantner (a.k.a. nephros)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Gantner (a.k.a. nephros) 2010-02-26 18:05:25 UTC
+++ This bug was initially created as a clone of Bug #215881 +++

Version 72 has a couple of nice new features (color output! yay!) and generally works better on my system.

Simple version bump works, although here I added the following change:

-DEPEND="virtual/ada"
+DEPEND="|| ( dev-lang/gnat-gcc dev-lang/gnat-gpl )"
Comment 1 Peter Gantner (a.k.a. nephros) 2010-02-26 18:08:04 UTC
Created attachment 221353 [details, diff]
updated Makefile patch
Comment 2 Peter Gantner (a.k.a. nephros) 2010-02-26 18:22:10 UTC
(In reply to comment #0)
 
> Simple version bump works, a
> -DEPEND="virtual/ada"
> +DEPEND="|| ( dev-lang/gnat-gcc dev-lang/gnat-gpl )"

Sorry, that should read:

-DEPEND="virtual/ada"
+DEPEND="|| ( dev-lang/gnat-gcc dev-lang/gnat-gpl )
+       sys-libs/ncurses
+       sys-libs/readline"

Comment 3 Torsten Veller (RETIRED) gentoo-dev 2010-03-04 13:04:11 UTC
If gnat-gcc wouldn't take that long to compile...

| -DEPEND="virtual/ada"
| +DEPEND="|| ( dev-lang/gnat-gcc dev-lang/gnat-gpl )"

Why? It should be the same.

> and generally works better on my system.

Did you modify the alpine ebuild to apply the (renamed) patches? http://homepage.ntlworld.com/phil.brooke/topal/rel-72/README.html#pine-patches
Comment 4 Peter Gantner (a.k.a. nephros) 2010-03-04 17:34:16 UTC
(In reply to comment #3)
> If gnat-gcc wouldn't take that long to compile...
Yea, but then it compiles bug-free programs, right? ;)

> | -DEPEND="virtual/ada"
> | +DEPEND="|| ( dev-lang/gnat-gcc dev-lang/gnat-gpl )"
> 
> Why? It should be the same.

I was under the impression it was preferred to do away with virtuals. I may be misinformed there.

> > and generally works better on my system.
> 
> Did you modify the alpine ebuild to apply the (renamed) patches?
> http://homepage.ntlworld.com/phil.brooke/topal/rel-72/README.html#pine-patches

Yes. My local ebuild has the following in src_prepare:

         if use topal; then
                if has_version \<=net-mail/topal-64 ; then
                        epatch /usr/share/topal/patches/${P}.patch
                elif has_version \>=net-mail/topal-65 ; then
                        epatch /usr/share/topal/patches/${P}.patch-1
                        epatch /usr/share/topal/patches/${P}.patch-2
                else
                        die "could not find suitable patch at /usr/share/topal/patches/!"
                fi
        fi

Come to think of it, I did not try to recompile alpine after installing topal-72, however I have been using topal-67 + alpine-2.00[topal] (from homegrown ebuilds) without issues for some time now, and the patches did not change from 67 -> 72 so I wager they are safe.
Comment 5 Torsten Veller (RETIRED) gentoo-dev 2010-03-05 14:09:02 UTC
Fixed. Thanks


(In reply to comment #4)
> I was under the impression it was preferred to do away with virtuals. I may be
> misinformed there.

You are :)

> Yes. My local ebuild has the following in src_prepare:
> 
>          if use topal; then
>                 if has_version \<=net-mail/topal-64 ; then

alpine-2.00-r3 depends on >=topal-72 now so it doesn't need the distinction.
I'll remove the old versions (alpine, topal) soon.