Created attachment 18956 [details, diff] Fix for bug. - Clear up language in several places. - Added and corrected yet more tags. - Removed link to Virtual private servers. Target page not updated in 2003 project seems stalled.
A couple of problems with the diff. Notice where you add the <path> for /tmp? You didn't do it for the second occurance of "/tmp" later on in the line. Where you tell the user to chmod the init script: Shouldn't the init script already be +x? If not, a bug needs to be filed about the chmodding. On the line that starts "If the policy states...," you need a comma after "week" becase you're using an if-then statement. On the line "This will cause the kernel," "can contain payload with other information then you think" should be worded "can contain payload with other information than you think." The line "Gcc trampoline support" should read "GCC trampoline support." In fact, list items do not need to include periods. It's a matter of preferrence, but I do not add periods (nor inital capitals unless it's a proper word) if the bullet is not a complete sentence. The line that begins "And configure your MISC_OTHER": should not have double punctuation at the end ("!" instead of "!."). The line "Documentation can be found at <uri>http://www.pureftpd.org</uri>" lacks a period at the end of the sentence. Also I do not condone the usage of passive tense. If it read "One can find documentation," that would be preferrable. (Apparently you use the clause "Documentation can be found" often. It does not really matter to me what tense you use, but passive is not generally de facto.) Other than that, you've done a good job. I may have missed a few things here or there, so I will look over it again later. However, I ask that you make the above changes and submit a new patch. I will review the new patch and commit it, if approved. Thanks
Created attachment 19024 [details, diff] Fix for bug. -All problems should be fixed in this patch. I have to mention that several of the issues pointed out was not introduced in the previous patch. -The /etc/init.d/quotas file is not part of the standard init files and thus have to be created. Therefor I think the chmod +x is in place. -I've changed the documentation sentences to the one proposed and tried to vary it a bit. It is indeed used in quite a few places. -A bunch of new corrections and updates. Geez I got carried away there:-) -Fixed URL for SANS. -Commented out most of the Bind section because it seems hopelessly out of date. Will check others later. -Kerneli seems rather inactive though there seems to be some activity on their mailing lists and a lot of spam there too. A search on Gentoo Forums only returns 19 matches and none with kerneli in the subject. Is it worth having the chapter if nearly nobody are using it? http://sourceforge.net/project/stats/index.php?report=months&group_id=30957 Not having English as your native language makes it a bit harder to get it right. In that regard I have a question wether to write it's or it is and don't or do not? Other than that thank you for the comments and I hope this will fix all issues.
"It's" is an abbreviation for "It is". So "It's 20 degrees" == "It is 20 degrees". "Its" is more possession-like. Like "his". So "The ISO and its ancestors".
I'm currently at "@@ -839,20 +826,15 @@" of the patch (22%), will continue tomorrow (see this comment as my personal bookmark :)
Nice patch. Reviewed and committed.
