Bug 305783 – sys-boot/syslinux - respect CFLAGS?

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jeroen Roovers (RETIRED) 2010-02-18 17:57:19 UTC]

I have only just "fixed" sys-boot/syslinux-3.84 so it respects CC, LDFLAGS and CFLAGS. About the latter I'm having some second thoughts since I don't know in what ways it can break through having the odd (maybe even the even) CFLAGS introduced. We could simply undo the CFLAGS changes if it turns out to make an unbootable system. :)

Index: syslinux-3.84.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/sys-boot/syslinux/syslinux-3.84.ebuild,v
retrieving revision 1.2
diff -u -B -r1.2 syslinux-3.84.ebuild
--- syslinux-3.84.ebuild        18 Feb 2010 17:40:22 -0000      1.2
+++ syslinux-3.84.ebuild        18 Feb 2010 17:54:28 -0000
@@ -41,8 +41,6 @@
                sample/Makefile \
                utils/Makefile \
                -e '/^LDFLAGS/d' \
-               -e 's|-Os||g' \
-               -e 's|CFLAGS[[:space:]]\+=|CFLAGS +=|g' \
                || die "sed failed"
 }

[Comment 1 Jeroen Roovers (RETIRED) 2010-02-18 17:58:53 UTC]

Seems I left out a bit as well, since it still uses -g:

[...]
i686-pc-linux-gnu-gcc -Wp,-MT,syslinux.o,-MMD,./.syslinux.o.d -O2 -pipe -Wall -march=athlon-xp -W -Wall -D_FILE_OFFSET_BITS=64 -g  -I. -I.. -I../libfat -I../libinstaller -c -o syslinux.o syslinux.
[...]

Either we go all the way or we simply keep CFLAGS as they are hardcoded in the Makefiles, I guess.

[Comment 2 SpanKY 2010-02-18 18:01:06 UTC]

syslinux produces boot loader type code which is why i never screwed with the binaries and/or flags

if you really want to respect CFLAGS, do USE=custom-cflags

[Comment 3 Jeroen Roovers (RETIRED) 2010-02-18 18:03:36 UTC]

Good point.

[Comment 4 Jeroen Roovers (RETIRED) 2010-02-18 18:28:15 UTC]

It now uses IUSE=custom-cflags.

[Comment 5 Chí-Thanh Christopher Nguyễn 2010-02-18 21:10:28 UTC]

The nostrip patch can be dropped now that the Makefile no longer modifies LDFLAGS.

[Comment 6 Jeroen Roovers (RETIRED) 2010-02-19 15:35:06 UTC]

(In reply to comment #5)
> The nostrip patch can be dropped now that the Makefile no longer modifies
> LDFLAGS.

I see you dropped that already.