Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 305679 - app-arch/unzip won't cross compile from x86_64 to x86 due to bad regex
Summary: app-arch/unzip won't cross compile from x86_64 to x86 due to bad regex
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-17 23:44 UTC by David James
Modified: 2010-03-23 04:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix for broken regex (unzip-cross-compile-patch.txt,572 bytes, text/plain)
2010-02-17 23:56 UTC, David James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David James 2010-02-17 23:44:22 UTC
The unzip ebuild currently expects that all instances of "AS=GCC" in the unzip Makefile have spaces after them. This is not always the case. To fix this, we should update the ebuild to look for word breaks instead of spaces.

Reproducible: Always

Steps to Reproduce:
1. Try to cross-compile the unzip package to x86 from a x86_64 machine

Actual Results:  
The following error message is printed:

gcc -Di386   -x assembler-with-cpp -c -o crc_gcc.o crc_i386.S
crc_i386.S: Assembler messages:
crc_i386.S:203: Error: suffix or operands invalid for `push'
crc_i386.S:204: Error: suffix or operands invalid for `push'
crc_i386.S:205: Error: suffix or operands invalid for `push'
crc_i386.S:206: Error: suffix or operands invalid for `push'
crc_i386.S:207: Error: suffix or operands invalid for `push'
crc_i386.S:208: Error: suffix or operands invalid for `push'
crc_i386.S:292: Error: suffix or operands invalid for `pop'
crc_i386.S:293: Error: suffix or operands invalid for `pop'
crc_i386.S:294: Error: suffix or operands invalid for `pop'
crc_i386.S:295: Error: suffix or operands invalid for `pop'
crc_i386.S:296: Error: suffix or operands invalid for `pop'
crc_i386.S:297: Error: suffix or operands invalid for `pop'
make[1]: *** [crc_gcc.o] Error 1

The above error message occurs because a 64-bit compiler is being used to compile 32-bit assembler. Updating the ebuild to correctly replace gcc with i686-pc-linux-gnu-gcc fixes the issue.

Expected Results:  
The unzip package should correctly compile to x86 from x86_64.
Comment 1 David James 2010-02-17 23:56:50 UTC
Created attachment 220117 [details]
Fix for broken regex

This patch fixes the broken regex which fails to replace assembler commands at the end of the line.
Comment 2 SpanKY gentoo-dev 2010-02-18 09:21:26 UTC
i prefer \< and \> over \b, but that's me
Comment 3 SpanKY gentoo-dev 2010-03-23 04:01:40 UTC
committed now; thanks for the patch

http://sources.gentoo.org/app-arch/unzip/unzip-6.0-r1.ebuild?r1=1.10&r2=1.11