Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 305175 - app-portage/gentoolkit - eclean not suggesting ALL versions of files for removal
Summary: app-portage/gentoolkit - eclean not suggesting ALL versions of files for removal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 237964
  Show dependency tree
 
Reported: 2010-02-15 01:54 UTC by ta2002
Modified: 2010-04-06 19:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ta2002 2010-02-15 01:54:37 UTC
# emerge -p --depclean

>>> These are the packages that would be unmerged:

 sys-kernel/gentoo-sources
    selected: 2.6.25-r8
   protected: none
     omitted: 2.6.31-r6

 sys-kernel/gentoo-sources
    selected: 2.6.27-r10
   protected: none
     omitted: 2.6.31-r6

 sys-kernel/gentoo-sources
    selected: 2.6.28-r5
   protected: none
     omitted: 2.6.31-r6

 sys-kernel/gentoo-sources
    selected: 2.6.29-r5
   protected: none
     omitted: 2.6.31-r6

 sys-kernel/gentoo-sources
    selected: 2.6.30-r6
   protected: none
     omitted: 2.6.31-r6

>>> 'Selected' packages are slated for removal.
>>> 'Protected' and 'omitted' packages will not be removed.

Packages installed:   667
Packages in world:    68
Packages in system:   50
Required packages:    662
Number to remove:     5


No complaints there.

But:

# eclean -dp distfiles
 * Building file list for distfiles cleaning...
 * Here are distfiles that would be deleted:
 [  46.4 M ] linux-2.6.25.tar.bz2
 * Total space that would be freed in distfiles directory: 46.4 M

And:

# ls -al /usr/portage/distfiles/linux*
-rw-rw-r-- 1 portage portage 48601689 2008-04-17 03:13:18 /usr/portage/distfiles/linux-2.6.25.tar.bz2
-rw-rw-r-- 1 portage portage 50355835 2008-10-09 23:57:24 /usr/portage/distfiles/linux-2.6.27.tar.bz2
-rw-rw-r-- 1 portage portage 52665364 2008-12-24 23:43:25 /usr/portage/distfiles/linux-2.6.28.tar.bz2
-rw-rw-r-- 1 portage portage 56579370 2009-03-23 23:27:47 /usr/portage/distfiles/linux-2.6.29.tar.bz2
-rw-rw-r-- 1 portage portage 59435895 2009-06-10 03:22:13 /usr/portage/distfiles/linux-2.6.30.tar.bz2
-rw-rw-r-- 1 portage portage 61494822 2009-09-09 22:34:49 /usr/portage/distfiles/linux-2.6.31.tar.bz2

Why doesn't eclean suggest linux-2.6.2[789].tar.bz2 and linux-2.6.30.tar.bz2?

Just for completeness:

# grep sources /var/lib/portage/world
sys-kernel/gentoo-sources
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2010-02-17 15:20:52 UTC
Looks like you still have multiple SLOTted versions of sys-kernel/gentoo-sources that you're keeping around. Does eclean want to keep them around even after you have unmerged the older versions?
Comment 2 ta2002 2010-02-17 23:10:08 UTC
If I understand (no guarantee of that), I would have them slotted if I used slots in /var/lib/portage/world (which I don't - that is why I included that line).

I emerged one of the older versions (emerge -C gentoo-sources-2.6.27-r10 ), and now eclean does suggest:

 [ 409.7 K ] genpatches-2.6.27-12.base.tar.bz2
 [  40.5 K ] genpatches-2.6.27-12.extras.tar.bz2
 [  46.4 M ] linux-2.6.25.tar.bz2
 [  48.0 M ] linux-2.6.27.tar.bz2

so that did change things a bit.

I thought I saw the same behavior (don't remember for sure - wish I had paid more attention) with another package (one that couldn't be slotted at all). 

eclean only wanted to remove the oldest version in /usr/portage/distfiles (leaving multiple newer versions).
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2010-03-06 17:34:45 UTC
you did not say what version of gentoolkit this was, but...

throw_away_2000, I am nearing the end of a modular re-write of ecclean.  I did find a few holes in the logic, but they would have removed sources for deprecated packages that were still installed.  There were some other changes to the search logic to tighten it up.  I would appreciate some additional testing to see if the output of eclean -dp distfiles improves for you or if you find any errors.

the development repo can be found at http://code.google.com/p/genscripts/

the eclean re-write is in branches/getntoolkit_eclean/ 
it does not need to be installed to run. just follow the instructions at the above address to create and source a file with the correct paths for it to find the files. It will need to be edited to find the branches/gentoolkit_eclean/....  It will print an extra line at the beginning to inform you it is the development sources being run.  Although I have the code complete for distfiles I would not recommend running it without the -p --pretend switch.

Thank you
Comment 4 ta2002 2010-03-08 06:57:25 UTC
(In reply to comment #3)
> you did not say what version of gentoolkit this was, but...

That I can answer.

app-portage/gentoolkit-0.2.4.5

I am away for the week (and then will have a ton of stuff to do when I return), but will try to take a look at youc development version. No way I get to it before the weekend, though. Thanks.
Comment 5 Brian Dolbec (RETIRED) gentoo-dev 2010-04-06 16:58:20 UTC
It is in the -0.3.0_rc10 release that's just been committed.