Most ebuilds that call make_desktop_entry() assume that make_desktop_entry is like any other ebuild-callable function in ebuild.sh or eutils.eclass. This assumption is that make_desktop_entry will, like econf or epatch, call die() if their actions fail. make_session_desktop() is in a similar situation. I'm not sure if it's better to have this be a tracker for all bugs against ebuilds which misuse make_desktop_entry() or if I should suggest an alternative. For most uses, I think that make_desktop_entry() should be given an `e' so that it's called emake_desktop_entry(). The existing function should be deprecated and the new function should, for now, look like: ``make_desktop_entry $@ || die''
what exactly is the problem ? i dont see where the function can fail
(In reply to comment #1) > what exactly is the problem ? i dont see where the function can fail The function calls doins to which ebuilds are required to append ``|| die''. I can't think of anything more concrete, but it'd be nice to have a bit more consistency among ebuilds and eclasses. Some ebuilds have taken it upon themselves to do ``make_desktop_entry blah || die'', showing (I think) some confusion about make_desktop_entry().
and again, that doesnt fail. ive added the `die` to the eclass for sanity sake, but i see no example of it ever actually failing.
