Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 304133 - Move m68k, s390, sh profiles to stable (was: app-portage/gentoolkit-dev: Make "all" in ekeyword aware of testing-only arches)
Summary: Move m68k, s390, sh profiles to stable (was: app-portage/gentoolkit-dev: Make...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 326651
  Show dependency tree
 
Reported: 2010-02-09 14:54 UTC by Christian Faulhammer (RETIRED)
Modified: 2023-08-24 20:45 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Faulhammer (RETIRED) gentoo-dev 2010-02-09 14:54:29 UTC
With the mass of Prefix keywords which are testing-only (and will stay so for a long time), the "all" keyword is sometimes just useless.   It would be great if stabilising with all could excluce arches like mips, Prefix and the *-fbsd.
Comment 1 SpanKY gentoo-dev 2010-02-09 17:17:48 UTC
we're not going to hardcode random logic in random utils.  the state of a keyword needs to be tracked in the profile.  if it cant be, then it isnt going to be supported.

we could have 'all' extract all keywords from profiles.desc that have a stable listing ...
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-10 09:35:04 UTC
That sounds sane to me, as long as one can extract that information easily.
Comment 3 Ulrich Müller gentoo-dev 2010-02-11 09:02:25 UTC
(In reply to comment #1)
> we could have 'all' extract all keywords from profiles.desc that have a stable
> listing ...

This wouldn't work, e.g. s390 and sh profiles are only "dev" but ebuilds can be marked as stable for them.

(CCing emacs, as this also affects app-emacs/gentoo-syntax whose ebuild-mode-ekeyword function is kept in sync with ekeyword.)
Comment 4 SpanKY gentoo-dev 2010-02-13 00:16:09 UTC
i'm ok with moving sh/s390 into the stable profile category.  i'm not aware of them holding back sets of packages ...
Comment 5 Ulrich Müller gentoo-dev 2010-02-26 14:26:08 UTC
(In reply to comment #4)
> i'm ok with moving sh/s390 into the stable profile category.  i'm not aware of
> them holding back sets of packages ...

m68k would be affected too.
Comment 6 SpanKY gentoo-dev 2010-03-05 18:40:29 UTC
that's fine
Comment 7 Ulrich Müller gentoo-dev 2010-03-09 08:03:17 UTC
So how do we go on from here? Can you move m68k/s390/sh into stable, or should it be discussed in gentoo-dev first?
Comment 8 SpanKY gentoo-dev 2010-03-10 00:32:14 UTC
i'm not good enough with python/perl to get ekeyword to start parsing profiles.desc, so whoever is should operate on the assumption that that is the way we're going to go

as for moving those arch's profiles from "dev" to "stable", i can take care of that
Comment 9 Ulrich Müller gentoo-dev 2010-03-10 07:27:11 UTC
(In reply to comment #8)
> i'm not good enough with python/perl to get ekeyword to start parsing
> profiles.desc, so whoever is should operate on the assumption that that is
> the way we're going to go

Here's an implementation in Lisp, for app-emacs/gentoo-syntax-1.17. :-)
<http://sources.gentoo.org/viewcvs.py/emacs/gentoo-syntax/gentoo-syntax.el?r1=1526&r2=1534>

> as for moving those arch's profiles from "dev" to "stable", i can take care
> of that

Please do.
Comment 10 Christian Ruppert (idl0r) gentoo-dev 2010-07-02 16:46:01 UTC
This bug has been fixed in app-portage/gentoolkit-dev-9999, please test it and give me some feedback.
Thanks
Comment 11 Christian Faulhammer (RETIRED) gentoo-dev 2010-07-03 07:15:56 UTC
(In reply to comment #10)
> This bug has been fixed in app-portage/gentoolkit-dev-9999, please test it and
> give me some feedback.
> Thanks

 Thanks, works partly as intended.  Behaviour is interesting on several runs of ekeyword all:

$ ekeyword ~x86-freebsd ~x64-macos ~x86-fbsd ~mips claws-mail-themes-20100514.ebuild 
claws-mail-themes-20100514.ebuild
--- claws-mail-themes-20100514.ebuild   2010-06-12 08:44:09.000000000 +0200
+++ claws-mail-themes-20100514.ebuild.new       2010-07-03 09:15:03.334036948 +0200
@@ -11 +11 @@
-KEYWORDS="~alpha ~amd64 ~ppc ~ppc64 ~x86"
+KEYWORDS="~alpha ~amd64 ~mips ~ppc ~ppc64 ~x86 ~x86-fbsd ~x86-freebsd ~x64-macos"

$ ekeyword all claws-mail-themes-20100514.ebuild 
claws-mail-themes-20100514.ebuild
--- claws-mail-themes-20100514.ebuild   2010-07-03 09:15:03.334036948 +0200
+++ claws-mail-themes-20100514.ebuild.new       2010-07-03 09:15:07.542036738 +0200
@@ -11 +11 @@
-KEYWORDS="~alpha ~amd64 ~mips ~ppc ~ppc64 ~x86 ~x86-fbsd ~x86-freebsd ~x64-macos"
+KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 ~x86-fbsd ~x86-freebsd ~x64-macos"

$ ekeyword all claws-mail-themes-20100514.ebuild 
claws-mail-themes-20100514.ebuild
--- claws-mail-themes-20100514.ebuild   2010-07-03 09:15:07.542036738 +0200
+++ claws-mail-themes-20100514.ebuild.new       2010-07-03 09:15:11.917036738 +0200
@@ -11 +11 @@
-KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 ~x86-fbsd ~x86-freebsd ~x64-macos"
+KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 x86-fbsd ~x86-freebsd ~x64-macos"

$ ekeyword all claws-mail-themes-20100514.ebuild 
claws-mail-themes-20100514.ebuild
--- claws-mail-themes-20100514.ebuild   2010-07-03 09:15:11.917036738 +0200
+++ claws-mail-themes-20100514.ebuild.new       2010-07-03 09:15:42.026289567 +0200
@@ -11 +11 @@
-KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 x86-fbsd ~x86-freebsd ~x64-macos"
+KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 x86-fbsd x86-freebsd ~x64-macos"
Comment 12 Christian Ruppert (idl0r) gentoo-dev 2010-07-03 08:58:16 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > This bug has been fixed in app-portage/gentoolkit-dev-9999, please test it and
> > give me some feedback.
> > Thanks
> 
>  Thanks, works partly as intended.  Behaviour is interesting on several runs of
> ekeyword all:
> 
> $ ekeyword ~x86-freebsd ~x64-macos ~x86-fbsd ~mips
> claws-mail-themes-20100514.ebuild 
> claws-mail-themes-20100514.ebuild
> --- claws-mail-themes-20100514.ebuild   2010-06-12 08:44:09.000000000 +0200
> +++ claws-mail-themes-20100514.ebuild.new       2010-07-03 09:15:03.334036948
> +0200
> @@ -11 +11 @@
> -KEYWORDS="~alpha ~amd64 ~ppc ~ppc64 ~x86"
> +KEYWORDS="~alpha ~amd64 ~mips ~ppc ~ppc64 ~x86 ~x86-fbsd ~x86-freebsd
> ~x64-macos"
> 
> $ ekeyword all claws-mail-themes-20100514.ebuild 
> claws-mail-themes-20100514.ebuild
> --- claws-mail-themes-20100514.ebuild   2010-07-03 09:15:03.334036948 +0200
> +++ claws-mail-themes-20100514.ebuild.new       2010-07-03 09:15:07.542036738
> +0200
> @@ -11 +11 @@
> -KEYWORDS="~alpha ~amd64 ~mips ~ppc ~ppc64 ~x86 ~x86-fbsd ~x86-freebsd
> ~x64-macos"
> +KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 ~x86-fbsd ~x86-freebsd ~x64-macos"
> 
> $ ekeyword all claws-mail-themes-20100514.ebuild 
> claws-mail-themes-20100514.ebuild
> --- claws-mail-themes-20100514.ebuild   2010-07-03 09:15:07.542036738 +0200
> +++ claws-mail-themes-20100514.ebuild.new       2010-07-03 09:15:11.917036738
> +0200
> @@ -11 +11 @@
> -KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 ~x86-fbsd ~x86-freebsd ~x64-macos"
> +KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 x86-fbsd ~x86-freebsd ~x64-macos"
> 
> $ ekeyword all claws-mail-themes-20100514.ebuild 
> claws-mail-themes-20100514.ebuild
> --- claws-mail-themes-20100514.ebuild   2010-07-03 09:15:11.917036738 +0200
> +++ claws-mail-themes-20100514.ebuild.new       2010-07-03 09:15:42.026289567
> +0200
> @@ -11 +11 @@
> -KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 x86-fbsd ~x86-freebsd ~x64-macos"
> +KEYWORDS="alpha amd64 ~mips ppc ppc64 x86 x86-fbsd x86-freebsd ~x64-macos"
> 

Ok, I was able to reproduce everything except the first..
The stabilization part should be fixed now, please try again.
Comment 13 Christian Ruppert (idl0r) gentoo-dev 2010-07-03 09:47:00 UTC
Ok, just simplified my last commit, try r793 please.
Comment 14 Christian Faulhammer (RETIRED) gentoo-dev 2010-07-06 17:28:15 UTC
(In reply to comment #13)
> Ok, just simplified my last commit, try r793 please.

 Works as it should.  Leave this bug open?
Comment 15 Christian Ruppert (idl0r) gentoo-dev 2010-07-06 17:41:33 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > Ok, just simplified my last commit, try r793 please.
> 
>  Works as it should.  Leave this bug open?
> 

Thanks :)
Yep.
Comment 16 Christian Ruppert (idl0r) gentoo-dev 2010-07-19 20:13:56 UTC
This has been fixed in gentoolkit-dev-0.2.7.
Comment 17 Ulrich Müller gentoo-dev 2010-12-27 10:27:28 UTC
(In reply to comment #8)
> as for moving those arch's profiles from "dev" to "stable", i can take care
> of that

That part is not done yet, therefore reopening. AFAICS, m68k, s390, and sh are affected.
Comment 18 Christian Ruppert (idl0r) gentoo-dev 2012-04-23 02:53:32 UTC
(In reply to comment #17)
> (In reply to comment #8)
> > as for moving those arch's profiles from "dev" to "stable", i can take care
> > of that
> 
> That part is not done yet, therefore reopening. AFAICS, m68k, s390, and sh
> are affected.

Any progress here?
Otherwise please re-assign and change the summary.
Comment 19 Ulrich Müller gentoo-dev 2012-04-23 05:10:00 UTC
(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #8)
> > > as for moving those arch's profiles from "dev" to "stable", i can take care
> > > of that
> > 
> > That part is not done yet, therefore reopening. AFAICS, m68k, s390, and sh
> > are affected.
> 
> Any progress here?

Seems not. Reassigning to vapier.
Comment 20 Raúl Porcel (RETIRED) gentoo-dev 2012-08-26 18:55:55 UTC
Moving the profiles to stable means a lot of keywording work since there are some broken, USE-based deps right now in said arches...and some impossible cases in s390(s390 having X masked while some packages depend on X)
Comment 21 Ulrich Müller gentoo-dev 2013-09-20 04:57:32 UTC
Obsolete, by 20130917 council decision that these arches should no longer have stable keywords.
Comment 22 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-08-24 20:45:04 UTC
gentoolkit supports GLEP 72 which handles this nowadays (https://www.gentoo.org/glep/glep-0072.html)

commit 1a18160c8200fb444878538b127b30bb461e4c42
Author: Michał Górny <mgorny@gentoo.org>
Date:   Fri Apr 24 09:42:44 2020 +0200

    Extract profile reading code from eshowkw, with tests from ekeyword

    Signed-off-by: Michał Górny <mgorny@gentoo.org>

commit 5ed5adad0197d06d6f3dbe7d4ea16b2bf7e4ed2d
Author: Michał Górny <mgorny@gentoo.org>
Date:   Fri Apr 24 10:25:10 2020 +0200

    profile: Add initial support for arches.desc

    Signed-off-by: Michał Górny <mgorny@gentoo.org>