Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 302784 - app-portage/gentoolkit-dev-0.2.6.13: echangelog should prefer svn over bzr with bzr-svn
Summary: app-portage/gentoolkit-dev-0.2.6.13: echangelog should prefer svn over bzr wi...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 284680
  Show dependency tree
 
Reported: 2010-01-29 18:23 UTC by Martin von Gagern
Modified: 2010-03-14 19:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
echangelog-check_vcs_dir.diff (echangelog-check_vcs_dir.diff,1.62 KB, patch)
2010-01-29 19:37 UTC, Christian Ruppert (idl0r)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2010-01-29 18:23:12 UTC
I was a bit surprised to find that echangelog took quite a while when I tried to add a message to the svn-based java-experimental overlay. pstree and ps told me it was a "bzr root" command running somewhere in the background. I assume that because I've got dev-util/bzr-svn installed, bzr thought it might be responsible for svn repositories as well, so it went on and tried to create a revision cache of all the revisions in the subversion repository. Which of course takes time.

I suggest you check for svn first, and bzr only later on, to avoid such issues.
Comment 1 Christian Ruppert (idl0r) gentoo-dev 2010-01-29 19:05:33 UTC
It just picks bzr if there is a .bzr directory.
So if you have a svn repository and also a bzr repository inside of it it will choose bzr.
Comment 2 Christian Ruppert (idl0r) gentoo-dev 2010-01-29 19:07:31 UTC
Hm, ignore my previous comment..
I'll take a look at it.
Comment 3 Christian Ruppert (idl0r) gentoo-dev 2010-01-29 19:37:16 UTC
Created attachment 217868 [details, diff]
echangelog-check_vcs_dir.diff

Please try my patch, it adds support for exactly what I said in my first comment.
That might help in this case.
Comment 5 Martin von Gagern 2010-02-02 08:51:00 UTC
Sorry for the delay...

(In reply to comment #4)
> So please try
> http://sources.gentoo.org/.../echangelog?r1=688&r2=736

Works like a charm, and looks good as well.

One minor point, though: you might wish to write "sort(keys(%vcs))" instead of "keys(%vcs)" so you can ensure a consistent order in which vcs are checked. Nested vcs call for trouble in this setup, but that way you'd at least get reproducible trouble.

Will you mark this fixed once the new code got released?
Comment 6 Martin von Gagern 2010-02-02 09:02:40 UTC
Oh, and you might wish to introduce a command line switch so users can override the repository autodetection.
Comment 7 Christian Ruppert (idl0r) gentoo-dev 2010-02-02 18:30:11 UTC
(In reply to comment #5)
> Sorry for the delay...
> 
> (In reply to comment #4)
> > So please try
> > http://sources.gentoo.org/.../echangelog?r1=688&r2=736
> 
> Works like a charm, and looks good as well.
> 
> One minor point, though: you might wish to write "sort(keys(%vcs))" instead of
> "keys(%vcs)" so you can ensure a consistent order in which vcs are checked.
> Nested vcs call for trouble in this setup, but that way you'd at least get
> reproducible trouble.
Done.

> 
> Will you mark this fixed once the new code got released?
> 
Yep.

(In reply to comment #6)
> Oh, and you might wish to introduce a command line switch so users can override
> the repository autodetection.
Done :)

Comment 8 Christian Ruppert (idl0r) gentoo-dev 2010-03-14 19:50:02 UTC
Fixed in 0.2.6.13-r1.