Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 30269 - kdemultimedia fails to build with gcc-3.3.x
Summary: kdemultimedia fails to build with gcc-3.3.x
Status: RESOLVED WORKSFORME
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-03 13:08 UTC by Bryan Østergaard (RETIRED)
Modified: 2003-10-23 10:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
New ebuild (only adding the multiline-patch) (kdemultimedia-3.1.4-r1.ebuild.diff,749 bytes, patch)
2003-10-03 13:09 UTC, Bryan Østergaard (RETIRED)
Details | Diff
Patched kdemultimedia source fixing compile errors (kdemultimedia-3.1.4-gentoo-multiline.diff,14.55 KB, patch)
2003-10-03 13:10 UTC, Bryan Østergaard (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Østergaard (RETIRED) gentoo-dev 2003-10-03 13:08:23 UTC
kdemultimedia uses multiline string litterals which breaks compilation when
using gcc-3.3.x.

I'm attaching diffs to the kdemultimedia source and the 3.1.4-r1 ebuild.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Bryan Østergaard (RETIRED) gentoo-dev 2003-10-03 13:09:25 UTC
Created attachment 18693 [details, diff]
New ebuild (only adding the multiline-patch)
Comment 2 Bryan Østergaard (RETIRED) gentoo-dev 2003-10-03 13:10:22 UTC
Created attachment 18694 [details, diff]
Patched kdemultimedia source fixing compile errors
Comment 3 Joshua Kinard gentoo-dev 2003-10-04 16:47:37 UTC
KDE People want me to handle this?  It falls under all those other gcc-3.3
multi-line strigs bugs gcc-porting has been handling.
Comment 4 Caleb Tennis (RETIRED) gentoo-dev 2003-10-05 08:09:10 UTC
yes, if you would like please do.

I'm a a bit baffled how this is still in the source code - if it truly is
a multiline string problem is should have been resolved in the kde source
a long time ago.
Comment 5 Brandy Westcott (RETIRED) gentoo-dev 2003-10-05 18:39:49 UTC
kdemultimedia compiles fine here using gcc-3.3.1-r4. I'm not convinced
that kdemultimedia has a problem with multiline string literals. They
have used a "\" at the end of each line that lets things compile
nicely.

e.g. without the terminating "\":

	#include <stdio.h>
	int main() {
	  printf("multiline\n
	string");
	}

	# g++ -c program.cc
	test1.cc:3:8: missing terminating " character
	test1.cc:4:6: missing terminating " character
	test1.cc: In function `int main()':
	test1.cc:4: error: parse error before string constant

and with the terminating "\":

	#include <stdio.h>
	int main() {
	  printf("multiline\n\
	string");
	}

	# g++ -c program.cc
	#

As caleb pointed out, there would probably already have been a slew of
bug reports if kdemultimedia couldn't compile using gcc-3.3.x
Comment 6 Caleb Tennis (RETIRED) gentoo-dev 2003-10-06 09:03:10 UTC
Okay, according to http://lwn.net/Articles/33227/

the multi line string literals that were in the source file to begin with
should be valid (as Brandy also pointed out).  

What kind of compile errors are you getting here?
Comment 7 Bryan Østergaard (RETIRED) gentoo-dev 2003-10-06 13:49:11 UTC
Sorry, I can't reproduce this any more. I haven't updated gcc or anything
else, so I don't really know what happened.
Comment 8 Caleb Tennis (RETIRED) gentoo-dev 2003-10-23 10:32:57 UTC
Author says it's fixed on his end.