302446 – [patch] dev-php5/pecl-gnupg-1.3.1 sefault & lsf fixes

Bug 302446 - [patch] dev-php5/pecl-gnupg-1.3.1 sefault & lsf fixes

Summary: [patch] dev-php5/pecl-gnupg-1.3.1 sefault & lsf fixes

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	PHP Bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-01-27 12:33 UTC by Mike Baikov
Modified:	2010-03-28 19:08 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
ebuild (pecl-gnupg-1.3.1-r99.ebuild,719 bytes, text/plain) 2010-01-27 12:33 UTC, Mike Baikov	Details
LFS support (lfs-1.3.1.patch,228 bytes, patch) 2010-01-27 12:34 UTC, Mike Baikov	Details \| Diff
segfault fix (segfault-1.3.1.patch,366 bytes, patch) 2010-01-27 12:34 UTC, Mike Baikov	Details \| Diff
pecl-gnupg-1.3.1-r1.ebuild (pecl-gnupg-1.3.1-r1.ebuild,556 bytes, text/plain) 2010-03-28 01:34 UTC, Jamie Learmonth	Details
files/1.3.1/01-large_file_system.patch (01-large_file_system.patch,260 bytes, text/plain) 2010-03-28 01:35 UTC, Jamie Learmonth	Details
files/1.3.1/02-gpgme_new_seg_fault.patch (02-gpgme_new_seg_fault.patch,366 bytes, text/plain) 2010-03-28 01:35 UTC, Jamie Learmonth	Details
pecl-gnupg.tar (pecl-gnupg.tar,10.00 KB, text/plain) 2010-03-28 01:36 UTC, Jamie Learmonth	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mike Baikov 2010-01-27 12:33:01 UTC

Current unstable package pecl-gnupg-1.3.1 have two bugs:

1. Not support LFS (coming with new gpgme-1.2.0)
2. Segmentation fault in gpgme_new(), if you don't call gpgme_check_version() before.

Patches with new ebuild attached.


Reproducible: Always

Comment 1 Mike Baikov 2010-01-27 12:33:54 UTC

Created attachment 217585 [details]
ebuild

Comment 2 Mike Baikov 2010-01-27 12:34:33 UTC

Created attachment 217586 [details, diff]
LFS support

Comment 3 Mike Baikov 2010-01-27 12:34:53 UTC

Created attachment 217588 [details, diff]
segfault fix

Comment 4 Peter Volkov (RETIRED) gentoo-dev

2010-01-27 13:10:26 UTC

Thank you for report. Reassigning on maintainers. BTW, what is the origin of this patches and were they reported upstream? Getting items fixed upstream improves the speed of accepting patches.

Comment 5 Jamie Learmonth 2010-03-28 01:33:59 UTC

I have verified that both bugs are present and this package currently does not build. I am attaching a cleaned up ebuild and patch files for review.

The first patch is recommended here:
http://www.gnupg.org/documentation/manuals/gpgme/Largefile-Support-_0028LFS_0029.html

Comment 6 Jamie Learmonth 2010-03-28 01:34:46 UTC

Created attachment 225509 [details]
pecl-gnupg-1.3.1-r1.ebuild

Ebuild

Comment 7 Jamie Learmonth 2010-03-28 01:35:05 UTC

Created attachment 225511 [details]
files/1.3.1/01-large_file_system.patch

LFS Patch

Comment 8 Jamie Learmonth 2010-03-28 01:35:18 UTC

Created attachment 225513 [details]
files/1.3.1/02-gpgme_new_seg_fault.patch

Segfault Patch

Comment 9 Jamie Learmonth 2010-03-28 01:36:16 UTC

Created attachment 225515 [details]
pecl-gnupg.tar

Tarball of all files

Comment 10 Matti Bickel (RETIRED) gentoo-dev

2010-03-28 19:08:53 UTC

Thanks all for the fixes and your contribution. I've added pecl-gnupg-1.3.1-r1 to the tree (Jamies version minus a "cd ${S}" to make repoman happy :)

Oh, and i'm watching php-bugs, so no need to CC: me.