Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 302374 - [kde overlay] kde-base/kget-4.3.95 wont build if kde-misc/webkit-kpart-9999 is installed
Summary: [kde overlay] kde-base/kget-4.3.95 wont build if kde-misc/webkit-kpart-9999 i...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 21:52 UTC by Tomáš Linhart
Modified: 2010-02-08 12:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
kget-webkit.patch (kget-webkit.patch,1.96 KB, patch)
2010-01-26 21:54 UTC, Tomáš Linhart
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Linhart 2010-01-26 21:52:33 UTC
kde-base/kget-4.3.95 fails to build with kde-misc/webkit-kpart-9999.
The error messaage is:

/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:35:24: error: webkitpart.h: No such file or directory
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp: In member function 'void KGet_plug_in::slotShowDrop()':
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:114: error: expected type-specifier before 'WebKitPart'
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:114: error: expected '>' before 'WebKitPart'
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:114: error: expected '(' before 'WebKitPart'
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:114: error: 'WebKitPart' was not declared in this scope
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:114: error: expected primary-expression before '>' token
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:114: error: 'class QObject' has no member named 'view'
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:114: error: expected ')' before ';' token
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp: In member function 'void KGet_plug_in::showLinks(bool)':
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:162: error: 'WebKitPart' was not declared in this scope
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:162: error: 'part' was not declared in this scope
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:162: error: 'WebKitPart' cannot appear in a constant-expression
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:162: error: parse error in template argument list
/var/tmp/paludis/kde-base-kget-4.3.95/work/kget-4.3.95/kget/extensions/konqueror/kget_plug_in.cpp:162: error: no matching function for call to 'qobject_cast(QObject*)'
make[2]: *** [kget/extensions/konqueror/CMakeFiles/khtml_kget.dir/kget_plug_in.o] Error 1

I made a simple patch that fixes the problem for me.

Reproducible: Always

Steps to Reproduce:
1. install kde-misc/webkit-kpart-9999
2. emerge =kde-base/kget-4.3.95
Comment 1 Tomáš Linhart 2010-01-26 21:54:12 UTC
Created attachment 217503 [details, diff]
kget-webkit.patch

This patch fixes kget build problem
Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev 2010-01-27 11:48:32 UTC
Did upstream ACK that patch?
Is it somehow commited upstream?
Comment 3 Tomáš Linhart 2010-01-27 14:10:27 UTC
(In reply to comment #2)
> Did upstream ACK that patch?
> Is it somehow commited upstream?
> 

I haven't reported the problem upstream, so the answer is no. Should I file a bug at bugs.kde.org? Sorry for asking but I am still a newbie when it comes to bugs reporting :-)
Comment 4 Tomáš Linhart 2010-02-01 14:47:50 UTC
(In reply to comment #2)
> Did upstream ACK that patch?
> Is it somehow commited upstream?
> 

Seems to be fixed in KDE SVN trunk. See http://websvn.kde.org/?view=revision&revision=1073346 and some minor changes in further commits (especially revision 1083055)

It also should be fixed in the 4.4 branch, see http://websvn.kde.org/?view=revision&revision=1083210

The webkit support was first removed and later this was reverted and the problem got fixed. Version 4.3.98 was tagged in the meantime, so webkit integration is not a problem for 4.3.98...
Comment 5 Tomáš Chvátal (RETIRED) gentoo-dev 2010-02-08 12:24:27 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > Did upstream ACK that patch?
> > Is it somehow commited upstream?
> > 
> 
> Seems to be fixed in KDE SVN trunk. See
> http://websvn.kde.org/?view=revision&revision=1073346 and some minor changes in
> further commits (especially revision 1083055)
> 
> It also should be fixed in the 4.4 branch, see
> http://websvn.kde.org/?view=revision&revision=1083210
> 
> The webkit support was first removed and later this was reverted and the
> problem got fixed. Version 4.3.98 was tagged in the meantime, so webkit
> integration is not a problem for 4.3.98...
> 

Goodie. Sorry Tomas that i forgot to get some time to fix this bug.

We can consider it fixed i guess. :] I just tested it on 4.4.0 just to make sure and it compiled. :]
Comment 6 Tomáš Chvátal (RETIRED) gentoo-dev 2010-02-08 12:26:19 UTC
For bugreporting purposes it is quite simple:
if it is packaging issue (missing dep, compilation crash), then report to bugs.gentoo.org and we will assist with recommendation to report upstream or just fix it.
For runtime issues report directly to upstream. Like kmail loosing all imap mails is more of upstream issue with which we cant do much :] (upstream bugzilla is bugs.kde.org)