Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 301789 - games-puzzle/sgt-puzzles-8887 version bump
Summary: games-puzzle/sgt-puzzles-8887 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL: http://www.chiark.greenend.org.uk/~sg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-22 01:22 UTC by Denilson Sá Maia
Modified: 2010-04-01 16:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
sgt-puzzles-8887.patch (sgt-puzzles-8887.patch,974 bytes, patch)
2010-03-07 15:00 UTC, Denilson Sá Maia
Details | Diff
sgt-puzzles-8605-to-8887.patch (sgt-puzzles-8605-to-8887.patch,699 bytes, patch)
2010-03-07 15:42 UTC, Denilson Sá Maia
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denilson Sá Maia 2010-01-22 01:22:04 UTC
Please update the portage version of games-puzzle/sgt-puzzles. At the homepage, four more games were added: Keen, Magnets, Singles, Towers

I've tried to just copy/rename the ebuild, but it requires a patch that needs to be updated.
Comment 1 Denilson Sá Maia 2010-03-07 15:00:37 UTC
Created attachment 222493 [details, diff]
sgt-puzzles-8887.patch

Patch for 8887 version. There are now 5 new games in this version (Signpost has been added).

I've ported the old sgt-puzzles-8605-gentoo.patch to version 8887, and I have two comments about this patch:

1. The first portion of the patch replaces "\$(GTK_CONFIG)" by "pkg-config gtk+-2.0". Why can't it be done using sed, almost like the sgt-puzzles-99999999.ebuild does?

2. The second portion appears to just add LDFLAGS to the parameters, but removes the ULIBS (or ULDFLAGS in old version). Why? Since I couldn't see the reason, I'm keeping ULIBS var in this patch for 8887 (but maybe I just missed the reason).

Also, I do think that the ebuild should install the documentation from the tarball, even without depending on app-doc/halibut. The tarball already contains puzzles.txt and puzzles.chm, which are more than enough for standard use. There could be another useflag (build-extra-doc?) that builds extra documentation formats using halibut.

Finally, the ebuild for 8887 requires this change:
-        -e 's:= -O2 -Wall -Werror -ansi -pedantic -g:+= $(CPPFLAGS):' \
+        -e 's:= -O2 -Wall -Werror -ansi -pedantic -g:= $(CPPFLAGS):' \
Comment 2 Denilson Sá Maia 2010-03-07 15:42:20 UTC
Created attachment 222499 [details, diff]
sgt-puzzles-8605-to-8887.patch

Ebuild patch from 8605 to 8887. Contains the above fix for the sed line, and also installs pre-built documentation.

After all, the doc useflag means "Adds extra documentation"
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2010-04-01 16:42:13 UTC
sgt-puzzles-8906.ebuild is in portage.