Bug 301634 – net-libs/webkit-gtk-1.2.1 fails due to minimal TOC error

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Brent Baude (RETIRED) 2010-01-20 15:49:43 UTC]

webkit-gtk--1.1.15.4 fails due to minimal TOC error

[Comment 1 Brent Baude (RETIRED) 2010-01-20 15:56:42 UTC]

Created attachment 216981 [details]
ppc64 failure

[Comment 2 Tom Gall (RETIRED) 2010-01-22 19:55:48 UTC]

looking at it

[Comment 3 Tom Gall (RETIRED) 2010-01-24 03:56:32 UTC]

was able to recreate this on friday.

Engaged a number of the toolchain types .. who were looking at something similar from a different build ... so good timing. 

[Comment 4 Samuli Suominen (RETIRED) 2010-07-09 13:06:56 UTC]

Created attachment 238123 [details]
webkit-gtk-1.2.1-build-log.tar.xz

/usr/lib/gcc/powerpc64-unknown-linux-gnu/4.3.4/../../../../powerpc64-unknown-linux-gnu/bin/ld: WebCore/svg/.libs/libwebkit_1_0_la-SVGAnimateMotionElement.o(.text+0x1394): sibling call optimization to `WebCore::RenderObject::markContainingBlocksForLayout(bool, WebCore::RenderObject*)' does not allow automatic multiple TOCs; recompile with -mminimal-toc or -fno-optimize-sibling-calls, or make `WebCore::RenderObject::markContainingBlocksForLayout(bool, WebCore::RenderObject*)' extern
/usr/lib/gcc/powerpc64-unknown-linux-gnu/4.3.4/../../../../powerpc64-unknown-linux-gnu/bin/ld: final link failed: Bad value
collect2: ld returned 1 exit status

using binutils-2.20.1-r1, glibc-2.10, and gcc-4.3

[Comment 5 Pacho Ramos 2010-07-15 09:35:05 UTC]

Samuli, this could be solved by passing "-mminimal-toc" to CFLAGS on ppc64 as done by freebsd guys, can you check if it works for you?
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147725

[Comment 6 Samuli Suominen (RETIRED) 2010-07-15 09:36:56 UTC]

(In reply to comment #5)
> Samuli, this could be solved by passing "-mminimal-toc" to CFLAGS on ppc64 as
> done by freebsd guys, can you check if it works for you?
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147725
> 

I don't think using -mminimal-toc solves anything, it's a workaround at most. Otherwise it would have been done long ago...

[Comment 7 Gilles Dartiguelongue (RETIRED) 2010-12-23 17:43:29 UTC]

Is this still a problem with 1.2.5 btw ?

[Comment 8 Pacho Ramos 2011-01-04 21:59:51 UTC]

(In reply to comment #7)
> Is this still a problem with 1.2.5 btw ?
> 

And with 1.2.6? If still valid please check with 1.3.x releases since upstream is developing that one much more actively

[Comment 9 Kacper Kowalik (Xarthisius) (RETIRED) 2011-01-05 08:42:38 UTC]

(In reply to comment #8)
> (In reply to comment #7)
> > Is this still a problem with 1.2.5 btw ?
> And with 1.2.6? 
1.2.5, 1.2.6 still fails

[Comment 10 Pacho Ramos 2011-01-05 10:48:29 UTC]

In that case would be better to try with 1.3.x since I doubt upstream will ever fix it for 1.2

[Comment 11 Kacper Kowalik (Xarthisius) (RETIRED) 2011-01-05 18:34:36 UTC]

(In reply to comment #10)
> In that case would be better to try with 1.3.x since I doubt upstream will ever
> fix it for 1.2
unfortunately 1.3.9 fails here too:

  CXXLD  libwebkitgtk-3.0.la
/usr/lib/gcc/powerpc64-unknown-linux-gnu/4.4.4/../../../../powerpc64-unknown-linux-gnu/bin/ld: WebCore/rendering/.libs/libwebkitgtk_3_0_la-RenderObject.o(.text+0xac40): sibling call optimization to `WTF::RefCounted<WebCore::RenderStyle>::deref()' does not allow automatic multiple TOCs; recompile with -mminimal-toc or -fno-optimize-sibling-calls, or make `WTF::RefCounted<WebCore::RenderStyle>::deref()' extern
/usr/lib/gcc/powerpc64-unknown-linux-gnu/4.4.4/../../../../powerpc64-unknown-linux-gnu/bin/ld: final link failed: Bad value
make[1]: *** [libwebkitgtk-3.0.la] Error 1
make[1]: Leaving directory `/var/tmp/portage/net-libs/webkit-gtk-1.3.9/work/webkit-1.3.9'

[Comment 12 Pacho Ramos 2011-01-05 20:35:15 UTC]

Can you then attach an updated full build.log for 1.3.x in upstream report?
https://bugs.webkit.org/show_bug.cgi?id=42070

I don't think we will be able to solve this downstream if workaround commented in comment #5 doesn't work for you neither, then, better try to put all info in upstream report.

[Comment 13 Kacper Kowalik (Xarthisius) (RETIRED) 2011-01-08 10:43:40 UTC]

(In reply to comment #12)
> Can you then attach an updated full build.log for 1.3.x in upstream report?
> https://bugs.webkit.org/show_bug.cgi?id=42070
> 
> I don't think we will be able to solve this downstream if workaround commented
> in comment #5 
It works so how about adding (at least 1.2.6):
use ppc64 && append-flags "-mminimal-toc"
while we wait for gcc-4.6 and newer binutils?

[Comment 14 Pacho Ramos 2011-01-08 11:00:37 UTC]

I am fine with it, will take a look if no one beats me ;-) (feel free to add it yourself if works for you)

[Comment 15 Kacper Kowalik (Xarthisius) (RETIRED) 2011-01-08 11:23:41 UTC]

+  08 Jan 2011; Kacper Kowalik <[e-mail]> webkit-gtk-1.2.6.ebuild:
+  Workaround TOC errors wrt #301634
+

[Comment 16 Pacho Ramos 2011-01-08 13:18:45 UTC]

I think webkit and co (epiphany...) can be keyworded then, not?