Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 3015 - links-2.0_pre3.ebuild (Update ?)
Summary: links-2.0_pre3.ebuild (Update ?)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Seemant Kulleen (RETIRED)
URL:
Whiteboard:
Keywords:
: 2888 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-05-25 06:19 UTC by Defresne Sylvain (keiichi)
Modified: 2003-02-04 19:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
links-2.0_pre3.ebuild (links-2.0_pre3.ebuild,2.31 KB, text/plain)
2002-05-25 06:23 UTC, Defresne Sylvain (keiichi)
Details
links-2.0_pre3-r1.ebuild (links-2.0_pre3-r1.ebuild,2.91 KB, text/plain)
2002-05-27 12:25 UTC, Defresne Sylvain (keiichi)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Defresne Sylvain (keiichi) 2002-05-25 06:19:58 UTC
Hello,

  I've rewritten the ebuild for net-www/links to build the new links version
supporting graphic mode (using either svgalib, devfs of X) and javascript. This
ebuild define a new 'use' variable :

javascript - Enable javascript support in web-browser.

  This ebuild enable graphic mode if either X, svga or devfs is in ${USE}, but
I'm not sure if my handling of this detection is the good way (tm). But this is
the simpler way without defining another new use variable ...

Bye
Comment 1 Defresne Sylvain (keiichi) 2002-05-25 06:23:38 UTC
Created attachment 1135 [details]
links-2.0_pre3.ebuild

This is the promised ebuild. It is a rewrite from scratch ...
-- 
Keiichi
Comment 2 Defresne Sylvain (keiichi) 2002-05-25 06:26:03 UTC
Oups, I've forgotten to set the severity to enhancement ...
Sorry.
-- 
Keiichi
Comment 3 Seemant Kulleen (RETIRED) gentoo-dev 2002-05-26 09:15:23 UTC
*** Bug 2888 has been marked as a duplicate of this bug. ***
Comment 4 Seemant Kulleen (RETIRED) gentoo-dev 2002-05-26 18:06:29 UTC
Thanks. I have added this to portage and masked it for now.

Here's a question for you.  Have you tried running it as a regular user in a
console using the svgalib driver?  I always get permission i/o errors.  I am
thinking it is a devfsd thing, but I can't quite figure out what error that is,
exactly.
Comment 5 Defresne Sylvain (keiichi) 2002-05-27 12:25:30 UTC
Created attachment 1170 [details]
links-2.0_pre3-r1.ebuild

Hi !

  I've changed the ebuild to install links suid root when it is compiled with
svgalib support (since it need root privilege to use this library).  It now
also print a message when compiled with either svgalib support (cause it is
installed suid) or with fbdev (it need privileges to access /dev/fb/0, usually
given by putting the user in a group having read/write access to this device)
...

  I don't know if this is the right way to update this ebuild since the bug
report is now closed ...

Bye
-- 
Keiichi
Comment 6 Defresne Sylvain (keiichi) 2002-05-27 12:29:18 UTC
Hi

  (I don't know if you got the previous comment because a made my attachment
before reopening the bug).

  Basically, I've attached an ebuild that solve your problem with svgalib and
give additional information when compiling with fbdev support ...

  To see the attachment : http://bugs.gentoo.org/attachment.cgi?id=1170&action=view

Bye
-- 
Keiichi
Comment 7 Seemant Kulleen (RETIRED) gentoo-dev 2002-05-28 06:02:49 UTC
how safe is it to make this binary suid?
Comment 8 Defresne Sylvain (keiichi) 2002-05-30 07:10:29 UTC
Hi,

  From SVGALib authors :

> However, it is a myth that SVGAlib is a security risk. While SVGAlib apps
> must be setuid root, that privilege is given up immediately after execution.
> There is no need to be concerned. 

  But there is still the risk of bug in SVGALib and / or links initializtion
routines. I think it should be reasonably safe to set the SUID bit on links,
but there is still the possibilities of bug.

  I've choosen to install it because if the user request the svgalib driver
he really is aware of this security implication (because all application using
svgalib needs root privilege). If he doesn't want to take the risk, he should
not have 'svga' in his USE list ...

  But maybe the ebuild should only indicate that the svgalib driver will only
work is the user has root privileges (SUID binary / sudo / ...) and let
the user choose wheter or not he wants to set the SUID bit ...

  Let me know, and I'll change the ebuild in consequences ...
-- 
Keiichi
Comment 9 Seemant Kulleen (RETIRED) gentoo-dev 2002-06-17 22:56:35 UTC
Defresne,

links-2.0 final is out. I like the idea of informing the user to setuid if s/he
chooses to do so for svgalib...

Comment 10 Seemant Kulleen (RETIRED) gentoo-dev 2002-06-27 08:31:59 UTC
Defrense?
Comment 11 Seemant Kulleen (RETIRED) gentoo-dev 2002-07-03 19:44:04 UTC
set suid if svga in use