Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 301312 - net-misc/wget-1.12 has no SNI support
Summary: net-misc/wget-1.12 has no SNI support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-17 21:07 UTC by Andreas Nüßlein
Modified: 2010-08-21 16:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wget-1.12-sni.patch (wget-1.12-sni.patch,3.95 KB, patch)
2010-01-17 21:07 UTC, Andreas Nüßlein
Details | Diff
wget-1.12-r1 ebuild (wget-1.12-r1.ebuild,2.12 KB, text/plain)
2010-01-17 21:08 UTC, Andreas Nüßlein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Nüßlein 2010-01-17 21:07:16 UTC
wget-1.12 has no SNI support, but there is a patch (actually for 1.11something, but I modified it a bit)

Reproducible: Always

Steps to Reproduce:
wget https://subdomain.domain.tld/
Actual Results:  
ERROR: certificate common name “domain.tld” doesn’t match requested host name “subdomain.domain.tld”.
To connect to subdomain.domain.tld insecurely, use ‘--no-check-certificate’.



Expected Results:  
2010-01-17 22:06:28 (29.4 MB/s) - “index.html” saved [1264/1264]
Comment 1 Andreas Nüßlein 2010-01-17 21:07:50 UTC
Created attachment 216763 [details, diff]
wget-1.12-sni.patch
Comment 2 Andreas Nüßlein 2010-01-17 21:08:57 UTC
Created attachment 216764 [details]
wget-1.12-r1  ebuild
Comment 3 SpanKY gentoo-dev 2010-01-17 22:28:14 UTC
when you take patches from other places, you need to document the source in the patch itself.  you can see that here:
http://sources.gentoo.org/net-misc/wget/files/wget-1.12-sni.patch?rev=1.1

you also shouldnt post complete ebuilds -- just a unified diff.  makes it hard (useless) for developers to see what you actually changed.

wget-1.12-r1 now in the tree with that patch
Comment 4 Andreas Nüßlein 2010-01-17 22:31:42 UTC
thank you for the pointers

i honestly forgot to mention the source, whilst planing on doing so.

did you include the source now? your link only returns a 404 =(

well here it is: http://www.mail-archive.com/bug-wget@gnu.org/msg00263.html
Comment 5 SpanKY gentoo-dev 2010-01-17 22:48:40 UTC
the public viewcvs is behind the real cvs.  wait a bit and check again.
Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev 2010-08-21 06:51:00 UTC
This piece of code looks suspicious:

+bool
+is_ip_address (const char *name)
+{
+  const char *endp;
+
+  endp = name + strlen(name);
+  if (is_valid_ipv4_address(name, endp))
+    return true;
+#ifdef ENABLE_IPV6
+  if (is_valid_ipv4_address(name, endp))
+    return true;
+#endif
+  return false;
+}

Uses 'is_valid_ipv4_address(name, endp)' twice. Is it normal?
Comment 7 Sergei Trofimovich (RETIRED) gentoo-dev 2010-08-21 08:38:20 UTC
Reopening as there is 'is_valid_ipv6_address' guarded by #ifdef. Seems, it was the real intention.
Comment 8 SpanKY gentoo-dev 2010-08-21 16:59:02 UTC
please file a new bug