Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 30092 - build error in via-pmu.c ppc-sources-2.4.22-r1
Summary: build error in via-pmu.c ppc-sources-2.4.22-r1
Status: VERIFIED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC Linux
: High blocker (vote)
Assignee: David Holm (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-01 11:32 UTC by Jason Johnson
Modified: 2006-02-04 06:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Johnson 2003-10-01 11:32:03 UTC
compile errors out on via-pmu.c with a screenfull of errors. (mostly warnings)

Reproducible: Always
Steps to Reproduce:
1. ppc-sources-2.4.22-r1
2. make sure macintosh drivers | support for PMU based PowerMacs is enabled
3. build the kernel (make dep clean bzImage modules modules_install)

Actual Results:  
errors out on via-pmu.c, screen full of warnings.

Expected Results:  
compiled cleanly? :)

the reason for the lack of information above is because I found a fix. I love
groups.google.com. here is the patch:

--- drivers/macintosh/via-pmu.c.orig 2003-09-03 08:43:10.000000000 +0200
+++ drivers/macintosh/via-pmu.c 2003-09-03 08:42:51.000000000 +0200
@@ -1393,7 +1393,8 @@
   pmu_pass_intr(data, len);
  } else
         pmu_pass_intr(data, len);
-
+#else
+ }
 #endif /* CONFIG_PMAC_PBOOK */
  goto next;
 }

--- drivers/macintosh/via-pmu.c.old 2003-09-03 08:42:51.000000000 +0200
+++ drivers/macintosh/via-pmu.c 2003-09-03 08:46:08.000000000 +0200
@@ -493,7 +493,9 @@
  /* Create /proc/pmu */
  proc_pmu_root = proc_mkdir("pmu", 0);
  if (proc_pmu_root) {
+#ifdef CONFIG_PMAC_PBOOK
   int i;
+#endif
   proc_pmu_info = create_proc_read_entry("info", 0, proc_pmu_root,
      proc_get_info, NULL);
   proc_pmu_irqstats = create_proc_read_entry("interrupts", 0, proc_pmu_root,
-

please note that when i edited the file to patch it by hand, the line count for
the first chunk was off for me. The second line count was correct.

groups.google.com refference:
http://groups.google.com/groups?q=via-pmu.c&hl=en&lr=&ie=UTF-8&oe=UTF-8&selm=rzWi.3zx.5%40gated-at.bofh.it&rnum=1

Thanks.
Comment 1 Pieter Van den Abeele (RETIRED) gentoo-dev 2003-10-11 05:34:58 UTC
could you guys have a look?
Comment 2 David Holm (RETIRED) gentoo-dev 2003-10-12 15:25:37 UTC
I will have a look at this on monday or tuesday.
Comment 3 David Holm (RETIRED) gentoo-dev 2003-10-26 05:30:07 UTC
I have commited a fixed ppc-sources-2.4.22-r1 and ppc-sources-dev-2.4.22
to portage. Please test it.
Comment 4 Lars Weiler (RETIRED) gentoo-dev 2005-03-30 04:27:01 UTC
2.4 sources are deprecated on ppc.  Just closing this bug.